I have 3 name fields, first middle last.
The fields are arranged as %1 %2 %3 in RealName.
So I can display "John van Doe", but when there is no middel name I get "John Doe" (two spaces), because the space gets printed but not the field.
Is there a way to prefend this going in the DB?
Privatemsg does name suggestions and I'm betting users will start to delete the extra space when mailing others, with errors etc.

CommentFileSizeAuthor
#10 d7-realname-doublespaces-5479052-10.patch652 bytesmustanggb
#4 realname.double_spaces.patch464 bytesfranz
#1 realname.double_spaces.patch472 bytesfranz

Comments

franz’s picture

franz
any
Location Montréal
commented
Status: Active » Needs review
StatusFileSize
new realname.double_spaces.patch472 bytes

Had the same issue, patch should do it.
Must rebuild names for changes to take effect (I know this is obvious, but if someone lands here out of nowhere, could save some time).

YK85’s picture

YK85 commented

subscribing

Status: Needs review » Needs work

The last submitted patch, realname.double_spaces.patch, failed testing.

franz’s picture

franz
any
Location Montréal
commented
Status: Needs work » Needs review
StatusFileSize
new realname.double_spaces.patch464 bytes

Trying again

verta’s picture

verta commented

Subscribing, will test dev if it is committed. Thanks for the patch.

franz’s picture

franz
any
Location Montréal
commented

You can also test with the patch itself before being commited, as this helps it get commited. =)
http://drupal.org/patch/apply

botris’s picture

botris
Primary language Dutch
Location Creuse, France
commented

Sorry for the late reply. Confirming patch works. Thanks.

franz’s picture

franz
any
Location Montréal
commented
Status: Needs review » Reviewed & tested by the community

RTBC then?

mustanggb’s picture

mustanggb commented

Needs port to D7

mustanggb’s picture

mustanggb commented
Version: 6.x-1.x-dev » 7.x-1.x-dev
StatusFileSize
new d7-realname-doublespaces-5479052-10.patch652 bytes

Attached is D7 port

franz’s picture

franz
any
Location Montréal
commented
Status: Reviewed & tested by the community » Needs review

D6 was not committed, but patch on #4 was RTBC. Patch #10 needs testing on D7, is that right?

mustanggb’s picture

mustanggb commented

Doesn't hurt for someone else to do a double check I guess

ceefour’s picture

ceefour commented

Hi!

Sorry OOT...

I just want to express that this RealName module is TOTALLY AWESOME! Very useful!

Definitely one of the first modules I would install on any Drupal website... other than views and pathauto, that is.

THANK YOU!

P.S. I hope users are able to comment directly on a module's "wall" on Drupal.org... but currently there's no such feature :(

dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented
Version: 7.x-1.x-dev » 6.x-1.x-dev
Status: Needs review » Patch (to be ported)

This has already been committed back with http://drupalcode.org/project/realname.git/commit/b52ca8a901aad0fe2f6c78... so moving back to D6.

dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented
Status: Patch (to be ported) » Fixed

Committed to 6.x-1.x with http://drupalcode.org/project/realname.git/commit/0dccca36badd4e0e178c59...

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

franz’s picture

franz
any
Location Montréal
commented

Hadn't notice it before, but I'd just like to say it doesn't hurt to attribute authorship or just credit on commit message.