In 2.x, it was possible to display the gallery node's comments on each image node within the gallery instead of the image's comments itself based on a setting.
While "cool", I'm not sure of the practicality of this setting. I think that the user expectation thanks to facebook et al, is that I can comment on each image specifically.
In case you couldn't tell, I'm in favor of leaving this feature in 2.x :) Does anyone use this feature?
| Comment | File | Size | Author |
|---|---|---|---|
| #7 | use-gallery-comments-on-image-nodes_978364.patch | 4.65 KB | nibblebot |
Comments
Comment #1
scroogie commentedPersonally, I don't think we need this. We preach the standard-based architecture of node gallery, and displaying other nodes comments is against that imho.
Comment #2
justintime commentedWorks for me!
Comment #3
nibblebot commentednew user to node_gallery here. I would really like to have gallery comments show up on all the image node pages so that there is only one set of comments for a gallery.
If nobody else wants this, I will port this myself and submit a patch. I just don't understand why you wouldn't want this feature at least as an *option*.
edit: I definitely need this feature for our large site. I'll be porting and submitting patch shortly. If you don't need it, i'll just keep it under my local custom patches.
Comment #4
scroogie commentedWell, the problem I have with the feature is that it messes with a core drupal feature and makes it inconsistent. If a user submits a comment from an image page, do you save it for the gallery or for the image? And what happens if the admin moves that specific image to a different gallery? Do you move the comment?
It just doesn't work for me.
Comment #5
nibblebot commentedI agree that the hack for $node->comment and the inability to preserve image comments if an image is moved to another gallery are behaviors that don't fit cleanly the gallery node and image node separation. For my use case however, it's completely necessary and I figure that others who want the awesome integration with plupload, sorting of images, gallery navigation, views integration, tokenized page URL for each image, etc. etc. but need the comments like this will appreciate it. I've completed the port and I'm packaging up now. I'm fine with just submitting the patch to this issue for those folks who absolutely need it if you don't intend on packaging with module.
Comment #6
justintime commentedPersonally, I don't think this should be included in NG core, but should be an add-on module. Thoughts?
Comment #7
nibblebot commentedHere is the comment display functionality ported to 3.x-dev
Comment #8
nibblebot commented@justintime - I think that's reasonable. The only thing is how to factor out the storage of the setting currently in node_gallery_relationships.settings and set in node_gallery_relationship_settings_defaults() function?
Comment #9
nibblebot commentedon a separate but related note, I'm adding functionality to inherit $gallery_node->taxonomy into $image_node. Thoughts on integration?
Comment #10
justintime commentedre: #9: http://drupal.org/project/node_gallery_taxonomy already does that
re #8, http://drupal.org/project/node_gallery_taxonomy shows you how - via hooks of course! http://drupalcode.org/viewvc/drupal/contributions/modules/node_gallery_t... lines 12 and 42.
Comment #11
justintime commentedMarking as postponed until we hear back from @nibblebot.
Comment #12
nibblebot commentedi've decided my approach was too much of a hack on your module and my use case more fits with a simple gallery node + imagefield cck fields with additional meta fields and using a custom pager that loads an imagefield and it's related data based on the ?page=N in the url.
Comment #13
justintime commentedokay, thanks for the follow up. Setting back to won't fix.