Come together with the global Drupal community in Rotterdam, 28 Sept – 1 Oct 2026. Sessions, contribution, connection, and Early Bird savings until 8 June.I was getting no returns from $events = gcal_find_events('2010-11-11T00:00:00', '2010-12-11T00:00:00'). I traced this into gcal.module and eventually added var_dump($content) at lines 836 and 841. It seems the preg_match code which is attempting to fix a newline problem is destroying the $content stiring.
Before 836 it dumps as ...
string(54919) "<?xml version='1.0' encoding='UTF-8'?><feed xmlns='http://www.w3.org/2005/Atom' xmlns:app='http://www.w3.org/2007/app' .... (rest removed)
After 840 it just shows as NULL.
| Comment | File | Size | Author |
|---|---|---|---|
| #4 | gcal-newline-fix.patch | 2.23 KB | coderintherye |
Comments
Comment #1
magpie5212 commentedI have been able to make an update that appears to fix the initial problem. Not sure how to create a patch - but if someone wants my source file to do that...
Comment #2
coderintherye commentedMagpie, yes please send me your source and I will create a patch and see about testing it.
Or you can check out: http://drupal.org/patch
It will tell you how to create a patch. If you are already using SVN, I like to just create patches by doing an svn commit, then making the change, then do:
svn diff gcal.module > gcal.patch
Cheers.
Comment #3
coderintherye commentedOk, got the code, patch coming up tomorrow sometime. Thanks magpie! :)
Comment #4
coderintherye commentedActually the patch is pretty straightforward. I'm going to go ahead an put it up here with the setting that it needs review, until I can review. To others, try at your own risk until then.
Comment #5
betz commentedYep, your patch did the trick, thanks for that!
Comment #6
coderintherye commentedExcellent, I think I have commit access, though not sure, so Ill try later and see if I can add this in.
Comment #7
aacraig commentedYou do have write access, so commit away if the patch has been tested.