Closed (fixed)
Project:
Rules
Version:
7.x-2.x-dev
Component:
Rules Core
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
22 Nov 2010 at 12:31 UTC
Updated:
9 Jun 2012 at 19:51 UTC
Jump to comment: Most recent file
It is probably called by the features integration, but it should be called when building data (that should be obvious). But line 56 tells me that Rules doesn't like to alter his stuff (third argument shows wether alter hooks should be called).
$defaults = rules_gather_data('rules_defaults', 'all', FALSE);
Can anyone explain me why?
| Comment | File | Size | Author |
|---|---|---|---|
| #6 | rules.rules_defaults_alter.patch | 841 bytes | franz |
| #3 | rules.rules_defaults_alter.patch | 633 bytes | franz |
Comments
Comment #1
franzJust so you know, I've removed the third argument and so on so far it is working. I'm working with features, and I had to change my own features-exported rules on an alter implementation to fix Workflow State ids (as we export rules from one installation into another, sids may be different).
Comment #2
fagoI don't think there is hook like that in d6? In d7 there is + it makes sense to me, so feel free to roll a patch.
Comment #3
franzYes, there is. Actually, would be more appropriate to say, there is support for it. Well, AFAIK the patch is actually just changing that argument, but I think there should be an appropriate testing. For me it worked well so far.
Comment #5
klausiPatch does not apply, see http://drupal.org/patch/create
Comment #6
franzyeah, didn't know patches made with diff couldn't be used by simpletest.
Comment #7
franzops...
Comment #9
franz#6: rules.rules_defaults_alter.patch queued for re-testing.
Comment #10
fagoWe'll also need to the add in the according API docs in the rules.api.php file.
Comment #11
mstef commentedWorks for me.
Comment #12
franzAt this point, this should get rolled to D7
Comment #13
mitchell commentedOld issue. Waiting on:
Comment #14
franzIf this is set to postponed, we will wait forever.
Comment #15
klausiWe have hook_default_rules_configuration_alter(), what is missing here?
Comment #16
mitchell commentedMarking as fixed as per #15. Please reopen if this change isn't right.