Add html to the commitlog views message field, and update the commitlog css to make longer messages wrap and pad properly and look nice.

CommentFileSizeAuthor
#4 970200-shippable_views.patch31.85 KBsarah_p

Comments

sarah_p’s picture

sarah_p commented
Component: API module » Commit Log
sarah_p’s picture

sarah_p commented
Issue tags: +git sprint 7

Adding git sprint 7 tag.

sarah_p’s picture

sarah_p commented

The Meta Issue regarding this is #970200: Create shippable commit views

sarah_p’s picture

sarah_p commented
StatusFileSize
new 970200-shippable_views.patch31.85 KB

This also covers #1010212: User should be able to page through commitlog views and I also placed a copy of the patch on #970200: Create shippable commit views:
This patch changes the commitlog view/page in the following ways:
- Pager
- Pre-tags that wrap and look generally legible
- Moves the add/removed lines (although this may change later after Mike's additions)
- Hides the Operator ID
- Moves the "Action" field above the file instead of in the middle. (May try to mimic github on this by using an image to represent the action committed, probably next sprint)
- Cleans up the text sizes a little

Image in Firefox in Mac OSX - https://img.skitch.com/20101231-durteg9tx1fya928mb8nehj25k.jpg

sdboyer’s picture

sdboyer commented
Status: Active » Fixed

Looks good here. Committed, thanks!

sdboyer’s picture

sdboyer commented
Issue tags: +git phase 2

adding phase 2 tag

marvil07’s picture

marvil07 commented
Status: Fixed » Needs work

Re-opening this.

This patch removed commitlog_global_commits views, so it breaks commitlog module main functionality: list commits.

I was going to revert this, but the commit is for three issues at the same time, so waiting on a more informed opinion than mine for now.

marvil07’s picture

marvil07 commented
Status: Needs work » Fixed

Ok, it was fixed at http://drupal.org/cvs?commit=473242

sarah_p’s picture

sarah_p commented
Assigned: sarah_p » mikey_p
Status: Fixed » Needs work

This is only fixed on the global commit views, not the vc_git_global_commits view, since mikey_p is handling the views I'm assigning this to him although this may be a duplicate of #1026440: Fix Commit Log views structure and html types. since it involves adding pre-tags.

sdboyer’s picture

sdboyer commented

Seems like this has been addressed, now?

sarah_p’s picture

sarah_p commented
Status: Needs work » Needs review

Should be good to close on my end.

eliza411’s picture

eliza411 commented
Status: Needs review » Fixed

They are wrapping. Marking fixed.

Status: Fixed » Closed (fixed)
Issue tags: -git phase 2, -git sprint 7

Automatically closed -- issue fixed for 2 weeks with no activity.

Issue tags: +git phase 2, +git sprint 7

Restoring issue tags, see #2125755: System messages removed all issue tags during D7 upgrade.

  • Commit 014dfe0 on repository-families, drush-vc-sync-unlock by sdboyer: 
    Issues #979058, #1010212, #970200 by sarah_p: Assorted improvements to...

  • Commit 014dfe0 on repository-families by sdboyer: 
    Issues #979058, #1010212, #970200 by sarah_p: Assorted improvements to...