Hi,

I saw in the version history that you said you added the repeat reminders to the Node Reminder module, but in looking at the module code, I don't see any options anywhere to set this. I tried rolling the patch on the current version (1.4) as well as the 1.3 version, but had no luck.

Is this feature still a work in progress or am I missing something somewhere? Thanks in advance!

Comments

indytechcook’s picture

indytechcook commented

Yes, it appears as if the patch here #673468: Repeat Reminders was overwritten. Fixing now.

hot_sauce’s picture

hot_sauce commented

Thanks for the quick response. Were you able to correct the patch?

indytechcook’s picture

indytechcook commented

The change was committed and is part of the -dev package. Please test then I will create a 1.5 release.

hot_sauce’s picture

hot_sauce commented

Hmm..did you commit a dev release? It may still be waiting to be approved to be posted in the commit, but the last thing that I see on the main module page (and under releases) is the 1.4 version from June, no -dev version.

I'll check back in a couple of days.

hot_sauce’s picture

hot_sauce commented

Hi indythecook,

I still don't see an updated patch or dev or 1.5 version of the module. I tried re-rolling the patch on the 1.3 version and it failed to properly apply and when I tried to install it, it took down the whole site.

Could you please post a link to the corrected patch or at least the dev version that you are talking about? It does not show up on the module page anywhere and I don't see any new commits.

Sorry to keep bugging you about this, its a great module that I really need to get working for a site I'm working on :)

hot_sauce’s picture

hot_sauce commented

Hi indytechcook - could you please post the commit or a dev version of the module? I never was able to test it as you requested since I don't see it anywhere on the project page. Much appreciated!

indytechcook’s picture

indytechcook commented
Status: Active » Needs review

I very much apologize for this. I just realized that I never created a dev release. It is there now and the package will be created in the next 12 hours.

Please post back with comments and I will adress much more quickly.

hot_sauce’s picture

hot_sauce commented
Status: Needs review » Postponed

Hi indytechcook,

I appreciate you posting the dev version of the module, but I actually was able to recreate what I needed for the site I was working on with Rules in the time before you put up the dev version of the module so I never actually had a chance to test out the dev version before it was posted. And since the project is now finished, I don't really have a scenario to test it against :(

I put "postponed" for this but feel free to close it if you want to. If I come across a need for this great module again (and I'm sure I will) then I'll be happy to make some comments and test out the dev version for full feedback.

Sorry about the back and forth with it, everything else about the module works great, and thank you for the hard work!

fizk’s picture

fizk commented
Status: Postponed » Closed (fixed)

Reminders has been fixed and committed.