forms_api_reference.html - managed_file example code needs modification

Sounds like a reasonable suggestion. Thanks.

This hasn't been added to the FAPI documentation, and made me spend the last hour :)

Updated priority so it gets noticed and we save someone from having the same error.

There are a lot of problems with that page, because it's a beast and very difficult to edit. We're trying to resolve that problem, but it hasn't been done yet.

This particular issue may have caused you some pain (and I'm sorry it did), but it is not any more major than any of the other documentation issues.

FAPI reference file is in the Documentation project now.

Here's what's in the managed_file example right now:

  // Load the file via file.fid.
  $file = file_load($form_state['values']['my_file_field']);
  // Change status to permanent.
  $file->status = FILE_STATUS_PERMANENT;
  // Save.
  file_save($file);

Here's how I propose to change it, adding the call to file_usage_add:

  // Load the file via file.fid.
  $file = file_load($form_state['values']['my_file_field']);
  // Change status to permanent.
  $file->status = FILE_STATUS_PERMANENT;
  // Save.
  file_save($file);
  //Record that the module (in this example, user module) is using the file. 
  file_usage_add($file, 'user', 'user', $account->uid);  

(Without the call to file_usage_add, file_managed_file_validate produces an error upon saving the form, saying that the uploaded file may not be referenced.)

Looks good to me, except for the missing space in

 //Record that the module (in this example, user module) is using the file. 

I suppose we need a patch? Or do you want to commit this directly once the change is RTBCed?

As I just learned in #8 of #800162: Documentation problem with forms_api_reference.html: give function params for all callbacks, forms_api_reference.html is not patched currently. So RTBCing this.

@sven.lauer
Thanks for the review!

Fixed in both D7 and D8.

but now when i press remove button file is not physically removed from directory and from DB as well. yes field is empty but why not from other sources.

@sani723

This issue is just about documentation. If you are having problems with the functionality, you need to find an issue that deals with that or open another issue.

Please could you tell me where i have to place your addition , in which file pleas e, this problem is going to make me crazy!!!

In the Documentation git repository, the file is under developer/topics.

Oh sorry. I thought you were talking about resolving this issue, and I didn't realize you were looking for programming help. This isn't a good place to ask for programming help...

There are several support options listed if you click on "Support" at the top of Drupal.org, which will take you to:
http://drupal.org/support

There you can find out about the Drupal IRC channels, and the Forums, which are our two main support mechanisms in the Drupal community.

Good luck with your issue!

thanks dear , you teached me :)