Replace mkdir('my/path/') with mkdir('my/path') [#97945]

On my web hosting with

open_basedir (set to my homedir)
safe_mode On
safe_mode_gid On

i had problem with configure garland theme into new colors. I have get numerous errors related with mkdir() and copy() files.
I have examine this problem and i get this solution:

In color.module is on line 214

  $paths['target'] = $paths['color'] .'/'. $id .'/';

On my hosting function mkdir() don't allow this but if i change

  $paths['target'] = $paths['color'] .'/'. $id;

mkdir() work with no problem.

There is $paths['target'] used too in some more lines - i moddified this lines with $paths['target'] . '/' and now works color.module without problem.

Comment	File	Size	Author
#3	color.module_1.patch	1 KB	havran
#3
#1	color.module_0.patch	2.1 KB	havran
#1

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

File	Size
color.module_0.patch	2.1 KB

Comment #2

Steven CreditAttribution: Steven commented 17 November 2006 at 03:46

Status:

Needs review

» Needs work

Or you could just add the slash to the target path after doing the mkdir. That way, you avoid inserting slashes everywhere. Also, the code style is bad.

File	Size
color.module_1.patch	1 KB

Comment #4

havran CreditAttribution: havran commented 24 November 2006 at 12:40

Status:

Needs review

» Reviewed & tested by the community

Please get some attention for this simple task. :) I had downloaded latest version of Drupal 5 (dev) and this error is still here. This simple patch working.

Comment #5

Dries CreditAttribution: Dries commented 24 November 2006 at 12:49

Code looks good now but I can't reproduce the problem. Maybe someone else can test this patch?

Comment #6

havran CreditAttribution: havran commented 24 November 2006 at 13:24

Maybe is problem in my webhosting specific PHP and/or Apache configuration. Simple example - mkdir('some/new/directory/') for some reason don't working, do not create directory and i get errors - mkdir('some/new/directory') working perfect.

Comment #7

havran CreditAttribution: havran commented 24 November 2006 at 13:37

After some searching on Google

http://www.google.com/search?q=php+mkdir+trailing+slash+problem&ie=utf-8...

Maybe i have source of this problem, my provider has modified PHP

This server is protected with the Suhosin Patch 0.9.5
Copyright (c) 2006 Hardened-PHP Project

But I think use no trailing slash in mkdir() is not bad idea.

Comment #8

drumm

he/him

NY, US

CreditAttribution: drumm commented 25 November 2006 at 08:52

Status:

Reviewed & tested by the community

» Fixed

Looks like this was committed.

Comment #9

drumm

he/him

NY, US

CreditAttribution: drumm commented 25 November 2006 at 08:54

Status:

Fixed

» Reviewed & tested by the community

No, it hasn't, I just confused myself.

Comment #10

drumm

he/him

NY, US

CreditAttribution: drumm commented 25 November 2006 at 08:59

Status:

Reviewed & tested by the community

» Fixed

Doesn't hurt anything by being there, code style is good, and it fixes some versions of PHP. COmmitted to HEAD.

Comment #11

havran CreditAttribution: havran commented 25 November 2006 at 09:27

Thanks.

Comment #12

(not verified) CreditAttribution: commented 9 December 2006 at 09:30

Status:

Fixed

» Closed (fixed)

Comment #13

dkatzman CreditAttribution: dkatzman commented 9 March 2007 at 10:51

Version:	5.0-beta1	» 5.0
Priority:	Normal	» Critical
Status:	Closed (fixed)	» Active

This SAFE MODE THING is so frustrating guys... After MONTHS noone has come up with a usable (by all) unswer to this and the derived problems (like changing colors to Garland)?

I tried the fix here but the code in my color.module was already identical to the fix you propose... Guess I have an updated version...

Any new ideas? Thanks in advance!

D. KATZMAN, MBA
CEO, The Mythos Group
# www.secretia.com
# www.unmentor.com
# www.mythos.es
# www.jewishculturela.org
# www.profesorblog.com
# www.drbolsa.com
# www.certifik.org