Automatically output all non-empty tags, option to output empty tags

Working through your comments:

• "Enabled meta tags" - agreed.
• The 'search' option items should be enabled by default.
• The "Show in edit form" boxes should default to 'checked'.
• The 'use the default tag' options are redundant:
  • "Never" option is worthless, if you don't want a default option then don't assign one.
  • "When the meta tag is empty" should how it always works.

I added a new issue for the search engine integration: #984346: Remove the 'search' customization options

I'm tempted to say this should be on v6.x-1.12, just because otherwise the module is currently a massive turkey, see how many people are having problems because of how the configuration has gotten stupid: #860304: Meta tags do not appear on the page (and others).

Changing this to a v6.x-1.12 blocker.

Lets make this even simpler.

Not going to tackle this in the next release, we'll do it afterwards.

Bumping the priority as it'll be an important fix.

Am refocusing this ticket to cover the output handling differently.

Right now the 6.x-1.x branch adds options to the Nodewords settings page so that you have to manually tell the system which of the metatags are actually outputted, regardless of which will actually contain values (see attachment).

This is a pretty horrible UX.

What I propose is changing it to the following:

• All non-empty tags are outputted, i.e. anything that does not === "" after all of the hooks have finished.
• Add an option to allow all tags to be outputted, regardless of their values; this would lead to blank values, but there may be cases where this is needed.

Another idea I had was to change the output workflow as follows:

• Add an option to control the output, which would have three options:
  1. Automatically output all tags that are not empty.
  2. Automatically output all tags, even if they are empty.
  3. Only output the following tags.
• Move the existing checkboxes, for controlling which tags are output, underneath the three options and use some JS to hide the fields until option #3 is selected.
• For backwards compatibility, for existing installs assign the setting that controls the above to option #3, but for new installs set it to #1.

This would allow for existing configurations to work as-is, but also make it easier for new installations.

Taking this off the blockers list.

This adds a new checkbox (variable "nodewords_output_non_empty") to the main settings page that controls whether all non-empty meta tags are output (the default) or whether the legacy method of controlling individual tags is used.

I decided to commit this, it's one of the module's biggest WTF's and I'm happy to have a solution for it.

You know, on second thought there's *no* point for 99% of sites to *not* display all meta tags.

Ok, this patch completely removes the options for controlling which meta tags are output and outputs all tags.

#17: nodewords-n979618-17.patch queued for re-testing.

Committed. Begone, demons of obnoxious usability.