When creating a view with more than one content type including the kaltura thumbnail field, the not existing thumbnail image is displayed as an "image not found-icon" also for the other non kaltura content types. Actually also when activating the Hide if empty-Option. Is there a quick way to solve this?

CommentFileSizeAuthor
#6 979620-views_fields_cleanup.patch8.66 KBxurizaemon

Comments

patrickroma’s picture

This also is an issue for version 6.15. See #963198: Thumbnails broken on CCK nodes. Firefox doesn't show this error, but IE, Safari and Chrome.

edit:

When the Thumbnail belongs to the correct kaltura content type and its shown, the path is: http://cdnbakmi.kaltura.com/p/376531/sp/37653100/thumbnail/entry_id/1_0r...
without belonging:
mysite.com/width/115/height/115

patrickroma’s picture

Ok, here's the solution:
change in node_kaltura_entry.module 682 to 685:

if ($node->link_thumb || $teaser)
    return '<div class="kaltura_thumb"><a href="'. url('node/'. $node->nid) .'"><img src="'. $node->kaltura_thumbnail_url . $size_str .'" '. $extra .' /></a></div>';
  else
    return '<div class="kaltura_thumb"><img src="'. $node->kaltura_thumbnail_url . $size_str .'" '. $extra .' /></div>';

to:

if ($node->link_thumb || $teaser) {
    if (!empty($node->kaltura_thumbnail_url)) {
      return '<div class="kaltura_thumb"><a href="'. url('node/'. $node->nid) .'"><img src="'. $node->kaltura_thumbnail_url . $size_str .'" '. $extra .' /></a></div>';
    }
  }
  else {
    if (!empty($node->kaltura_thumbnail_url)) {
      return '<div class="kaltura_thumb"><img src="'. $node->kaltura_thumbnail_url . $size_str .'" '. $extra .' /></div>';
    }
  }

This solves the thumbnail problem. We should also apply this in kaltura_media_remix.

patrickroma’s picture

Status: Active » Needs review
xurizaemon’s picture

Thanks Patrick.

Will apply above fix, with consideration to #685900: Use theme & translation layers & FAPI (should replace inline HTML with theme layer while fixing).

xurizaemon’s picture

Title: Views: Empty Thumbnail field does not hide » Views issues: Some fields do not hide, others do not work
Status: Needs review » Needs work

Thanks Patrick for raising this. Identified a few other minor issues with the Views implementation. The issue above, some similar ones with other fields, and a few others (eg download URL not working at all) should be resolved shortly.

I will make a branch on Github for this issue also, so if there's more testing to be done we can work on it there.

xurizaemon’s picture

Status: Needs review » Needs work
StatusFileSize
new8.66 KB

Github branch: https://github.com/GiantRobot/drupal-kaltura/tree/6.x-2.x-979620

Patch applies against DRUPAL-6--2.

xurizaemon’s picture

Status: Needs work » Needs review

Please review and report.

xurizaemon’s picture

Status: Needs work » Fixed

Committed to 6.x-2.x

Status: Fixed » Closed (fixed)
Issue tags: -views, -hide, -thumbnail

Automatically closed -- issue fixed for 2 weeks with no activity.