Posted by geerlingguy on November 23, 2010 at 10:40pm
5 followers
| Project: | FullCalendar |
| Version: | 6.x-1.x-dev |
| Component: | Code |
| Category: | bug report |
| Priority: | critical |
| Assigned: | Unassigned |
| Status: | closed (fixed) |
Issue Summary
I'm having trouble getting FullCalendar to display at all on either IE 6 or IE 7 under Windows XP SP3. It works great on IE8, but only my list of nodes loads in IE7/6 - I get 'Done, but with errors on page.' after the page loads.
Does anyone else have this problem?
Comments
#1
I'm getting a "Done, but with errors on page." Notice - and attached is the screenshot of IE's error report. I tried manually replacing the fullcalendar.js file with the latest (v1.4.9), but that didn't help either.
I did notice, when looking at the rendered page's source, that there's an odd whitespace difference for the 'timeFormat' line:
right: 'month agendaWeek agendaDay'},
timeFormat: {
agenda: 'h:mm{ - h:mm}'
},
But I'm not sure if that would cause any problems with IE.
#2
The error is attached here... oops.
Line: 220Char: 15
Error: Expected identifier, string or number
Code: 0
Here's that block of HTML from the rendered page:
$('.fullcalendar_event').each(function() {event_details = $(this).find('.fullcalendar_event_details');
events.push({
title: $(event_details).attr('title'),
start: $(event_details).attr('start'),
end: $(event_details).attr('end'),
url: $(event_details).attr('href'),
allDay: ($(event_details).attr('allDay') == '1'),
className: $(event_details).attr('cn'),
}); <!-- this is line 220, the curly bracket is character 15... -->
});
#3
Looking further into the issue, it looks like the comma on the last line is throwing IE6/7 for a loop - IE8, FireFox, Safari, Chrome, etc. etc. all ignore that comma, but IE 6 and IE 7 are completely stymied.
See for similar problem description: http://forumsblogswikis.com/2008/07/21/javascript-error-expected-identif...
I removed the trailing comma in views-view-fullcalendar.tpl.php, and the problem went away instantly (with both versions of fullcalendar.js.
Please see (and commit) the attached patch.
#4
#5
I caught and fixed this in #906112: handle drag and drop: creating events, rescheduling events.
#6
I'd prefer this get fixed asap, though, as I'm sure many people will be turned off by the module not working in IE7 at all. It might be best to commit this tiny patch immediately, if possible, and then continue work on #906112: handle drag and drop: creating events, rescheduling events (best to keep issues focused on specific issues, imo).
#7
Bug reports > feature requests.
Especially when it's a one character fix.
#8
http://drupal.org/cvs?commit=456062
#9
Automatically closed -- issue fixed for 2 weeks with no activity.
#10
I think I broke IE7 again....
When I googled I found this...
So IE7 is broken in latest stable release.
Maybe you can apply this quickfix to all branches...
Don't look at the name of the patch....
#11
#12
Yep.
#13
Committed to all branches.
Let's not do this again, okay? :)
http://drupal.org/cvs?commit=488098
http://drupal.org/cvs?commit=488100
http://drupal.org/cvs?commit=488104
#14
Automatically closed -- issue fixed for 2 weeks with no activity.