Service links on a front node

Reworked the patch and committed it, thank you!

I had the same problem with 6.x-2.1.

I just changed
if ($settings['link_to_front']) {
to
if ($settings['link_to_front'] || drupal_is_front_page()) {

in the _service_links_get_page_url function

worked for me

Thanks @2pha, pushed it!

Hi,
I have the same problem on D7, and I don't see any trace of the patch in the current 7.x-2.x-dev release.
Is this committed?

Thanks!

line 801 of service_links.module

Thanks for the quick reply!

_service_links_get_node_path()

  $path = "node/$node->nid";
  if (isset($node->uri)) {
    if (((object)$node->uri['path'] == $front_page) || ($path == $front_page)) {
      $path = '<front>';
    }
  }

On my site, $node->uri is empty, so this does not work.
Instead, you need this:

  $path = "node/$node->nid";
  if (
    ($path == $front_page) ||
    (isset($node->uri) && ((object)$node->uri['path'] == $front_page))
  ) {
    $path = '<front>';
  }

(linebreaks added only for readability in this post)

IC, I can't help you with that, I never had the problem when using this module.

Ok, I hope the maintainer will see this :)

What is the status of this issue? (I've noticed the problem too).

Corresponding patch.
All credit goes to donquixote.

I tested the patch (including clearing patches), but it didn't seem to work for me:

I was testing without using any short URLs, so that I could directly see the path that was being linked to.

When I clicked the Tweet button, there was still the /node path after my domain.

In otherwords:
- Expected to see: http://www.example.com
- Actually saw: http://www.example.com/node

Please let me know if there is anything different I should be doing to test this.

I can confirm the patch works for me with the tweet button as well.
I don't understand what could possibly be happening for you, juilangb. Would you eventually use some modules that plays with the front page (like "Front page" or similar)?

No, I don't use any modules like that.

The front page is just a view, directly set in the site settings.

Oh... This patch only changes the node behaviour. Let me see what could happen for Views.

In the meantime, as the issue is only for nodes, let's put the status back to "Needs Review".

Committed, thank you!