If you have skinr installed and are using garland (or any theme that does not have a base theme), you get piles of E_NOTICE notifications:

notice: Undefined index: base theme in /home/rfay/workspace/d6git/modules/system/system.module on line 942.

These are caused by skinr inappropriately calling system_find_base_themes(_system_theme_data(), $current_theme).

The attached patch fixes this particular warning. Please always work with E_NOTICE enabled and with errors and warnings to the screen.

CommentFileSizeAuthor
skinr.error_messages.patch611 bytesrfay

Comments

jacine’s picture

jacine
she/her
Location New York
commented
Status: Needs review » Closed (duplicate)

Hi @rfay.

This is a duplicate of this issue: #943782: _system_theme_data() causes PHP notices, but system_theme_data() causes themes to be disabled on update.

rfay’s picture

rfay
he,him
Primary language English
Location Palisade, CO, USA
commented

Hmm... Might be a duplicate but is unresolved in that issue... and it looks to me like this is the right way to fix it here.

jacine’s picture

jacine
she/her
Location New York
commented

As I wrote in that issue, _system_theme_data() doesn't work properly and that's why it's not being used.

I need @moonray to comment further on the technical reasons, but I know there is a specific reason, and that we were using _system_theme_data() first and needed to change it.

If you'd like to close out the other one and continue here, that's fine, but I there's no point in having 2 issues about the exact same thing, both with patches that try to fix it the same way open in here.

EDIT: errr, I meant _system_theme_data(). Sorry.