Closed (fixed)
Project:
Privatemsg
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
25 Nov 2010 at 06:12 UTC
Updated:
13 Dec 2010 at 08:00 UTC
Jump to comment: Most recent file
!author_iud is returning the author's name with a hard _uid;
if username(author) is john and user id is 45 I would expect !author_uid to return 45. But it actually returns john_uid
| Comment | File | Size | Author |
|---|---|---|---|
| #2 | author_uid_token.patch | 899 bytes | berdir |
Comments
Comment #1
elpy commentedI have the same issue in 6.x-1.3.
Comment #2
berdirConfirmed, attaching a patch for 6.x-2.x. Please test.
Comment #3
IWasBornToWin commentedI expect I should know this, but how do I actually attach a patch?
Comment #4
berdirhttp://drupal.org/patch/apply
Comment #5
IWasBornToWin commentedI don't see this happening anytime soon. Your link for applying patches sent me on a 4 hour journey only to find out how inadequate I feel about reading minds. (not your problem, mine :) This whole "cygwin" program and the baby-step approach here http://drupal.org/node/620014 has left me thinking i'm back in diapers. I haven't found anything that tells me how to communicate from my local computer to my website in order to run the patch command from cygwin. I see all sorts of documentation showing me how to run the command on my local file assuming I have a local development site, which I don't. So I do not see how I will be applying this patch via cygwin anytime soon. I will try to go over and look at the manual suggestion.
At the moment I have your patch file sitting in the privatemsg folder on my website. And a cygwin program sitting on my local hard drive. This is where I sit. It may be time for a walk and a cup of coffe. :) Thanks again for your quick replies.
Comment #6
berdirWell...
- For really simple patches like this one, you could patch it manually. Patch file syntax is quite simple. First, it says which file is changed, lines which start with a "+" are added, lines with "-" are removed, all other lines serve as context so that you or the patch program can find where to add what. If you look at the patch, it only adds a single line. You can do that yourself (without the "+")
- If you have SSH access to your website, you can download an ssh too like Putty (google) and then directly patch it there
- If not, download the privatemsg folder, apply the patch and then upload the folder again (or the changed files)
Comment #7
IWasBornToWin commentedThank you....makes a whole lot more sense....worked perfectly. And for others, the whole patching process is really just editing a text file. Or at least is was in this simple situation. I expect for bigger patches, there's a whole lot more editing going on. I simply fired up my ftp program...went directly to the file to be patched...opened it, replaced the --- line with the +++ line and then added the one + line where the patch indicated....saved....done. Maybe it's just me...but I wasn't grasping the concept, "patch".
Comment #8
berdirThanks for testing.
- This needs to be commited, so don't set it to fixed but RTBC. I suggest to read http://drupal.org/node/156119. The only issues that are usually set to fixed by someone else than me are support questions.
- Lines with "---/+++" just tell in which file you have to replace it.
Comment #9
berdirCommited to 6.x-2.x and 6.x-1.x, thanks for reporting and testing.