system_date_format_save() doesn't save localized date formats

+++ modules/system/system.module
@@ -3740,7 +3740,7 @@ function system_date_format_save($date_format, $dfid = 0) {
       // Only proceed if language is enabled.
-      if (in_array($langcode, $languages)) {
+      if (isset($languages[$langcode])) {

Disabled languages are contained in $languages, too, AFAIK.

Powered by Dreditor.

Thanks for clarifying!

Sorry, this needs tests.

Testbot says invalid patch file.

+++ modules/system/system.test
@@ -1044,6 +1044,70 @@ class DateTimeFunctionalTest extends DrupalWebTestCase {
+    $query = db_select('date_formats', 'df');
+    $query->addField('df', 'format');
+    $query->condition('type', 'short');
+    $query->condition('format', 'dmYHis');
+    $format = $query->execute()->fetchColumn();

Can you rewrite these queries to:

$format = db_select('date_formats', 'df')
  ->fields('df', array('format'))
  ->condition('type', 'short')
  ->condition('format', 'dmYHis')
  ->execute()
  ->fetchField();

Powered by Dreditor.

Rerolled the patch against the current 7.x branch and verified that the tests run successfully.

+++ b/modules/system/system.test
@@ -1048,6 +1048,74 @@ class DateTimeFunctionalTest extends DrupalWebTestCase {
   }
+  /**

Missing blank line.

2 days to next Drupal core point release.

Sorry for that, should be corrected now.

Thanks! Let's get this in.

Issue summary added. I also opened #1234848: language_list() doc is missing return value to address the (lack of) documentation for language_list().

Updated issue summary.

Committed and pushed to 8.x and 7.x. Thanks!