Valid URL Test

Hi Nicholas,

Thanks for your patch! Sorry for the late feedback.
Wouldn't it be better though to use valid_url($val, TRUE), as it seems like a more widely used use case to validate external URLs...
I'm not sure how the regex without $absolute = TRUE works, but it validates practically everything when i test it (including one word text entries).
Do you have a specific use case in mind where $absolute would have to be FALSE?

Updated patches in attachment, using $absolute = TRUE.
I'll have to figure out what the consequences of all of this are at some point.

According to patch and http://drupal.org/node/822146#comment-3080360 I put this in my module and it works fine for me,

/**
 * Implementation of hook_webform_validation_validators().
 */
function my_module_webform_validation_validators() {
  return array(
  	'valid_url' => array(
      'name' => "Valid URL",
      'component_types' => array(
        'textfield',
        'hidden',
        ),
      'description' => t("Validates that the user-entered data is a valid URL using Drupal's built in !link.", 
      array(
      	'!link' => l(t('valid_url'), 'http://api.drupal.org/api/drupal/includes--common.inc/function/valid_url')
      	
      )),
    ),
  );
}
/**
 * Implementation of hook_webform_validation_validate().
 */
function my_module_webform_validation_validate($validator_name, $items, $components, $rule) {
  if ($items) {
  	switch ($validator_name) {
      case "valid_url":
        foreach ($items as $key => $val) {
          if (!valid_url($val, TRUE)) {
            $errors[$key] = t('%item does not appear to be a valid URL.', array('%item' => $components[$key]['name']));
          }
        }
        return $errors;
        break;
    }
  }
}

Fixed in 1d058b3.

I think it is probably best not to include links to Drupal's API documentation in user-facing help text. The end user does not really care which of Drupal's API functions is used to validate the URL, and including a link to developer-oriented documentation is just confusing. Here's a patch against the latest 7.x-1.x that removes this part from the help text.

Aside from that, this looks good.

http://drupalcode.org/project/webform_validation.git/commitdiff/6ff2de1

Thanks, theunraveler.

Drupal 6 is no longer supported.