Come together with the global Drupal community in Rotterdam, 28 Sept – 1 Oct 2026. Sessions, contribution, connection, and Early Bird savings until 8 June.Lots of code style fixes based on the Drupal standards and using code-style.pl.
Changes include comments changed to phpdoc standard, lots of spacing and indention fixes, removal of some dead code, conversion of double quotes to single quotes when not necessary and the reverse when it made code easier to read.
| Comment | File | Size | Author |
|---|---|---|---|
| #2 | phpbb2drupal_codestyle.patch_0.txt | 7.26 KB | neclimdul |
| phpbb2drupal_codestyle.patch.txt | 86.6 KB | neclimdul |
Comments
Comment #1
beginner commentedCommitted, thanks.
Sorry for the delay: I am having serious internet connectivity problems this week.
Comment #2
neclimdulNo Worries about the delay. And a big woops from me. I forgot about the .install and phpbb_redirect.module. Attached is a patch that does code style updates to these as well.
Also, apparently we where not making the temp tables utf8. This would mean that old installs will not have utf8 tables. Converting them to utf8 probably doesn't matter as the content won't be updated but I've included an update anyways.
Comment #3
beginner commentedin .install, are you sure about the postgresql changes?
You seem to be changing more than is necessary, and maybe even too much.
pgsql has recently been patched by a postgre user, so I wouldn't want to destroy his work...
Comment #4
sammys commentedHi all,
I've looked over the postgresql changes made by @neclimdul and they fit with Drupal style guidelines. They are also correct. RTBC as far as postgresql changes go. Thanks @neclimdul (and whoever patched it for postgresql)!
Side note for @neclimdul: most core/EC CREATE TABLE code has NOT NULL before DEFAULT clauses. It doesn't matter, but figured it was worth a mention.
Cheers,
--
Sammy Spets
Synerger
http://synerger.com
Drupal core maintainer (PostgreSQL support) and E-commerce maintainer
Comment #5
beginner commentedThanks Sammy for the review.
Patch committed. Thanks :)
Comment #6
neclimdulGreat, thanks for the pointers Sammy and thanks for making sure I got it all right.
Comment #7
(not verified) commented