It's great to see that this module follows a standard. Here is some random feedback I either got from users or myself.

1. When I first saw the "full name" field, I was confused. I now understand this is made necessary by Drupal Commerce and it is also part of the xNL standard. However for sites who implement their own fields for storing this type of user profile data, there should be a way to remove/ignore these custom name fields. There are several reasons why this situation might occur: (1) installing addressfield on an existing site with existing profile data, (2) design choice in order to have better support with full fledged first/last name Fields, (3) several addresses might be linked to the same person in which case you do not want to store the name with each address.

2. When I first showed the form elements generated by addressfield to a bunch of users within a user profile edit form, they were all confused by the "Premise" field. They immediately asked for Street and Premise to be renamed to "Address 1" and "Address 2" because that's what most people are used to. That's also what Amazon uses for example: Only local images are allowed. (this image is actually borrowed from another issue of this module!). I implemented this in a custom site specific form_alter() but I suspect this feedback might reoccur.

From the two remarks above, maybe there is a need to make each column label editable and disabled.

CommentFileSizeAuthor
#12 983656-us_field_labels-12.patch774 bytesmikey_p
#6 addressfield_form_us.inc_.patch570 bytesjoelstein

Comments

jcarlson34’s picture

jcarlson34 commented

@scor I had the same reactions with 1 and 2 that you did.

While it is easy to modify addressfield_form_us.inc to change Street and Premise to Address 1 and Address 2, a subfield management system would be a great feature addition if possible.

damien tournoud’s picture

damien tournoud commented

I agree on (1): you should be able to say if you want a xNL or a xAL address. I thought it was already possible.

I strongly disagree on (2): the label of the fields and the order of the fields are country-specific. You can easily override it for your particular use case if you want to. That said, we could (should?) consider tweaking the default labels.

bryancasler’s picture

bryancasler commented

+1 For label tweaking

jcarlson34’s picture

jcarlson34 commented

Here's a vote for at least tweaking the US label to something other than 'Premise'.

Premise must be a term that's used in England or France but they definitely do not use that term here. Changing it to Address 1 and Address 2 or Street and Apt. # will confuse less of us Yanks. ;)

acouch’s picture

acouch commented

Another vote for changing the 'Street' and 'Premise' to 'Address 1' and 'Address 2' for US. We don't use 'Premise' in the US.

joelstein’s picture

joelstein commented
Status: Active » Needs review
StatusFileSize
new addressfield_form_us.inc_.patch570 bytes

+1 for "Address 1" and "Address 2" in the US. Patch attached.

bradhawkins’s picture

bradhawkins commented

+1 for changing 'Street' and 'Premise' to 'Address 1' and 'Address 2' for US.

henrijs.seso’s picture

henrijs.seso commented
Status: Needs review » Active

There should be a way to label and enable/disable fields per country. Current patch is not for issue in OP, it is US centric and would brake compability with xNAL standard, whatever that is. I don't know if features suggested in OP would not brake it too, but I'd rather support that approach.

BenK’s picture

BenK commented

Any update on this? I also find "Premise" to be really confusing.

jsenich’s picture

jsenich commented

Subscribing.

lauggh’s picture

lauggh commented

+1 Subscribing

mikey_p’s picture

mikey_p commented
Status: Active » Needs review
StatusFileSize
new 983656-us_field_labels-12.patch774 bytes

Updating p1 patch rolled from git.

damien tournoud’s picture

damien tournoud commented
Status: Needs review » Closed (won't fix)

The -reloaded branch has been merged. It comes with a new very flexible plugin system and has reasonable defaults for many countries in the world.

As part of this refactoring, the base fields also have more reasonable names. Feedback and testing welcome, but I think we can close this.

geerlingguy’s picture

geerlingguy commented
Status: Closed (won't fix) » Active

Could we consider the possibility of allowing per-field-instance (or even sitewide) label changes? I have had to form_alter way too many forms just to change the label on one of the fields...

damien tournoud’s picture

damien tournoud commented
Status: Active » Closed (won't fix)

I'm sorry, but we are not going to allow custom labels for each field. This would be putting ourselves between a rock and a hard place, because those needs to remain translatable, etc.

The proper way of doing that is to implement an address format plugin (see the example in the code), and use it in the fields you want.