On our site we allow people to pick up from our premises, which is "free" shipping. However, the cart has an error when you try to include a zero priced "free" shipping item.

We have worked around this by including the "pickup" shipping as having a cost of $0.01, but obviously not ideal.

Comments

xurizaemon’s picture

Status: Active » Postponed (maintainer needs more info)

Can you confirm that this only happens when using this payment processor to complete the transaction? I don't think there should be any shipping specific behaviour in this module.

Also: I have total faith that you can give me more to work with than "has an error" : http://drupal.org/node/73179 (please help me to help you)

... Hang on. You're trying to check people out with a $0.00 cart total? Through a payment processor?

amnestynz’s picture

StatusFileSize
new17.27 KB

There is definitely other things in the cart. Basically all of our products are "real" products so they all cost something. When we add them to the cart, there is no error until you pick the shipping method as "pickup". If the "Pickup" shipping method is listed as $0.00 (which it should be) then there is an error. The error message is the cryptic one that you get at Flo2Cash. It is attached as a jpeg below.

My developer thinks it is the fact that when you select "pickup" as a shipping method, Ubercart adds the shipping "item" as a "line item" in the cart, and since it should be $0.00, it therefore adds a line item which costs $0.00, which is why the error occurs.

I can confirm that currently my shipping method of "pickup" costs $0.01, and we do not get the error.

Thanks

xurizaemon’s picture

Title: Free Shipping Error » Exclude zero-cost items from submission to Flo2Cash (F2C throws unhelpful error if cart item costs $0.00)

Thanks Viv for clarifying after our chat today. Will look into it.

Sounds like we just need to exclude that item from the submission to Flo2Cash.

amnestynz’s picture

sweet, any update on this?

xurizaemon’s picture

Status: Postponed (maintainer needs more info) » Needs work

Oops, hadn't updated status so it was off radar.

Will try to get a look at this soon. I'll probably code for 6.x and then let you test patch for 5.x though!

atipton’s picture

Status: Needs work » Needs review
StatusFileSize
new1.29 KB

(this issue affects both 5.x and 6.x versions of the module)

The attached patch fixes this issue by suppressing all zero-cost products and shipping line items. These remain part of the order, but are not sent to the flo2cash gateway. As a result, on the flo2cash payment details page, items with no cost will not appear. They will remain part of the order and be displayed upon return from flo2cash.

berenddeboer’s picture

StatusFileSize
new874 bytes

Not sure where above patch went, can't download it. Here probably the same kind of patch.

xurizaemon’s picture

Yeah looks like that patch in #6 upset the d.o file attachment code, patch is where it ought to be but the link is borked.

http://drupal.org/files/issues/zerocostitems-983902-6.patch

Pretty much identical, Andrew wins on points for including "strongly recommended" curly braces :)

berenddeboer’s picture

Status: Needs review » Reviewed & tested by the community

Can we get that fixed? Use Andrew's patch, has comments.

xurizaemon’s picture

Version: 5.x-1.0 » 6.x-1.x-dev
Status: Reviewed & tested by the community » Fixed

thanks all, committed just now and should appear in next 6.x-1.x-dev and 5.x-1.x-dev

happy to drop a stable of this if requested

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

berenddeboer’s picture

Yes, put it in stable please.

xurizaemon’s picture

Done, release(s) should be up in five.