Project:flatforum
Version:4.7.x-1.x-dev
Component:Code
Category:bug report
Priority:normal
Assigned:PMunn
Status:closed (fixed)

Issue Summary

I'll be working on a PostgreSQL compatibility patch for this module. It currently has no support for PostgreSQL in the installer and it may have issues in the module itself.

Comments

#1

Status:active» needs review

Here's a patch to the install file that adds the PostgreSQL version of the table create command. From what I see in the module file, nothing needs to be tweaked to work with pgsql.

I ran this on my dev copy of my site and found no problems.

AttachmentSize
flatforum.install.pgsql.patch 490 bytes

#2

Hi,

Thanks for your work! I've reworked the patch a little to make the file more consistent (used heredoc syntax instead of concatenation). I don't have access to PostgreSQL right now, so would you please test this on a dummy installation before I update head and 4.7?

Thanks!

AttachmentSize
flatforum.install.patch.txt 724 bytes

#3

I wasn't able to apply your patch as written, so I copied its contents in by hand, tested the resulting install file out, and then generated a new patch, which is attached. It works for me.

AttachmentSize
flatforum.install.pgsql_0.patch 534 bytes

#4

Status:needs review» fixed

Thanks for going through all this trouble. I've committed the patch to HEAD and DRUPAL-4-7:
http://drupal.org/cvs?commit=46478
http://drupal.org/cvs?commit=46480

Thanks again for your contribution, and I hope you enjoy flatforum :)

#5

Status:fixed» closed (fixed)
nobody click here