Posted by WorldFallz on November 30, 2010 at 4:51pm
2 followers
Jump to:
| Project: | Visitor Info |
| Version: | 6.x-1.x-dev |
| Component: | Code |
| Category: | support request |
| Priority: | normal |
| Assigned: | Unassigned |
| Status: | active |
Issue Summary
Not sure if this is a bug or by design-- what, if anything, should appear in the gmap info box that pops up when a marker is clicked? I just downloaded the current dev, and the info boxes are empty. I'm thinking of creating a view that lists comments by ip and ideally I'd like to stick that in the info box along with info specified at admin/settings/visitorinfo.
Comments
#1
Hi WorldFallz,
Sorry I haven't had a chance to get this done over the weekend. I intend to upload a new version of this module which will be a 6.x-2.0 branch. I've got the code written and it's being tested right now. Basically I've decided to make the Visitor Info module rely upon the GeoIP API module to do all the geo lookups, etc. Especially because IPInfoDB.com recently changed their apis and are now requiring you to have an api key.
I went ahead and updated the 6.x-1 branch to include instructions about this and a box for one to paste in their api key. In case anyone wants to continue using the 6.x-1 branch they still can but will need to update to the latest 6.x-1.6. I neglected to do anything with the dev version so I'm assuming that is why your pop ups are empty.
In the 6.x-2.0 code I have removed the google stuff and the default map blocks. Now the module grabs the IP and uses the GeoIP API module to lookup all the information such as city, state, zip, lat. and long., etc. I've integrated it with Views so you can use GMap or OpenLayers to map the data and sort it however you want.
As I said, I just have not had time to actually release it but I did attach it the code here http://drupal.org/node/952328#comment-3754728 if you care to have a go at it.
Tim
#2
Whoa-- very nice. Lots of good stuff to come. Awesome job on this module!
One question though-- would you consider making the choice of ipinfodb vs geoip an admin setting? For sites with low traffic (typical every man type blog sites) having to maintain a geoip db, even if only monthly, seems way overkill. It's the main reason i use ipinfodb for my comment_country module-- i'd hate to lose this with the new version (at least as long as the ipinfodb key is free).
#3
Wow...I didn't know about Comment Country, thanks so much for the kudos! What do you think about me just keeping the 6.x-1 branch alive and using ipinfodb?
#4
It's your module so it's really up to you, but i find maintaining two separate versions like that can be a pain. Plus I think you were right to remove mapping in favor of using views, and gmap/open layers. I haven't had a chance to play around with the 2.x version yet but I'd be happy to roll a patch that makes it an option. Maybe open up a 2.x dev branch so I don't work on old code?