Hi,

The theme should not use theme_path() in sky_preprocess(), but rather drupal_get_path('theme', 'sky').

I am not sure if the former should work. However it does not work if any module has a preprocess function before. ( blocktheme was the problematic one in my case).

This does only break the admin menu, but I wondered why it was the case.

Best Wishes,

Fabian (LionsAd)

CommentFileSizeAuthor
sky-theme--fix-path-to-theme-as-its-not-always-working.diff817 bytesfabianx

Comments

jacine’s picture

jacine
she/her
Location New York
commented
Status: Needs review » Postponed (maintainer needs more info)

I'm not sure if this is correct or not, but can you elaborate more on the problems it's causing. You say it was causing issues with blocktheme, which I find odd and then you mention that it "only" breaks admin menu. I have no problem changing it if it's wrong, but, using that function during preprocess is a standard practice in Drupal theming. If you look at core themes in Drupal 7, you'll see it's used there as well.

fabianx’s picture

fabianx commented

Hi,

Yeah it was a really strange bug. I'll see if I can reproduce it with other combination of modules. Could be also a seldom occuring core bug.

Thanks for coming back to me.

Best Wishes,

Fabian

jacine’s picture

jacine
she/her
Location New York
commented
Status: Postponed (maintainer needs more info) » Closed (works as designed)

I'm going to close for now. Feel free to reopen with more details if the problem persists. Thanks!