Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.Not sure if this is really related to windows only. I was getting php warnings/notices after the shutdown function has outputted the cookie so the install cannot continue when there is a notice in the $cli_cookie variable not a cookie.
| Comment | File | Size | Author |
|---|---|---|---|
| #8 | drush-op-system.patch | 9.07 KB | greg.1.anderson |
| #7 | drush-si6-windows-985716-7.patch | 908 bytes | wapnik |
| #3 | drush-si6-windows-985716-3.patch | 653 bytes | wapnik |
| drush-si6-windows.patch | 505 bytes | wapnik |
Comments
Comment #1
greg.1.anderson CreditAttribution: greg.1.anderson commented@wapnik: Could you please confirm that your patch still works against HEAD? I reworked drush_shell_exec_interactive since you posted that.
Comment #2
wapnik CreditAttribution: wapnik commentedIt's not working with or without the patch.
Comment #3
wapnik CreditAttribution: wapnik commentedBut this is working fine.
Comment #4
greg.1.anderson CreditAttribution: greg.1.anderson commentedI'm a little confused by this patch. Why does turning off error reporting help the situation? A comment is needed explaining the motivation. Also, if you turn error reporting off, you should turn it back on again once the critical section has passed.
Comment #5
wapnik CreditAttribution: wapnik commentedAs mentioned in the post itself, on windows if you are running a command with a redirection 2>&1 and that command is php (as far as i've observed), notices which should normally appear before the output from the shutdown function are delayed and outputed later. Therefore you don't get the unserialized cookie (that's the output of the shutdown function) in the last line of the command's output, but a php notice. And the setup cannot continue then.
I cannot really figured out why is this happening. I only noticed this when using 2>&1 at the end of the command and expected behavior when using a command without a redirect. The fix for that was the first patch before you changed drush_shell_exec_interactive(). Now i don't see any other solution besides disabling those notices.
Comment #6
greg.1.anderson CreditAttribution: greg.1.anderson commentedOkay, I think that's fine, but the patch should include a comment. If error reporting must stay off for the full context of where $output is used, or if there is no way to turn it back on, then you do not need to turn it back on. Otherwise you should.
Comment #7
wapnik CreditAttribution: wapnik commentedSomething like this?
Comment #8
greg.1.anderson CreditAttribution: greg.1.anderson commentedEdit: Unrelated patch moved to #992170: drush usage of drush_op('system', ...) is inconsistent regarding expectation of return value (e.g. site-install)
Comment #9
greg.1.anderson CreditAttribution: greg.1.anderson commentedImproper hijacking of issue. #8 does not solve #7. I'm going to make a separate issue for #8, then commit #7.
Comment #10
greg.1.anderson CreditAttribution: greg.1.anderson commentedComment #11
greg.1.anderson CreditAttribution: greg.1.anderson commentedCommitted.