I am looking into issues between product kits and vats on a clinet. Most of the issues were missconfigurations but I found one improvement that it's needed to properly display on the cart.

There's a wider issue between product kits and uc_price() which I just reported in #986294: Product kits and price alter logic don't fit nicely. It might be interesting if you can take a look at that one well as see if there's anything you can chip in.

CommentFileSizeAuthor
#1 986306-product-kit-vat-on-cart.patch1.03 KBhanoii

Comments

hanoii’s picture

hanoii
Primary language Spanish
Location 🇦🇷UTC-3
commented
StatusFileSize
new 986306-product-kit-vat-on-cart.patch1.03 KB
longwave’s picture

longwave
he/him
Primary language English
Location UK
commented

I don't have a site that uses product kits that I can test this on, but if you are sure this is working for you I can commit it, as it doesn't seem like it could intrude on other cart items.

hanoii’s picture

hanoii
Primary language Spanish
Location 🇦🇷UTC-3
commented

It's definitely working for me. This was a quick consultancy work but it's likely that I will be doing a bit more, so if new things or issues related to this arise, I'll let you know.

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Status: Needs review » Fixed

Committed, thanks.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

tahiticlic’s picture

tahiticlic commented

Around line 1063 of uc_vat module, it should be :

<?php
    if (!isset($tax_subtotals[$id])) {
                  $tax_subtotals[$id] = 0;
                }
                $tax_subtotals[$id] += ($pk_node->sell_price+$pk_node->discount) * $pk_node->qty * $table[$i]['qty']['#default_value'] * ($tax->rate);
?>