Update the location bar of the browser

Indeed that's something waiting to be fixed for some time!

Thanks for the patch srjosh, but patch doesn't apply properly against 6.x-1.x-dev (new features are done allways against dev):

patching file ./theme/galleryformatter.js
Hunk #1 FAILED at 42.
Hunk #2 FAILED at 66.
2 out of 2 hunks FAILED -- saving rejects to file ./theme/galleryformatter.js.rej
patching file ./theme/galleryformatter.tpl.php
Hunk #1 succeeded at 28 with fuzz 2.

I think its because you created a new dir theme.new?

The easiest way to create a patch is:

1. checkout form cvs the appropriate branch: http://drupal.org/node/794682/cvs-instructions/DRUPAL-6--1
2. Make the changes you need to every file.
3. Run the following command form the module's root directory: cvs diff -up > ~/galleryformatter-[issue-number].patch

I was curious as to test this myself, so I made the few changes, and created a proper patch if anyone else wants to test this.

Although I admit it's a clever way to do it, I don't like the way we are tricking the browser, seems to me like a hack - a clever hack =)

The main reason not to commit this is that the deep linking would not work without JS turned on, since its the JS that gets the proper hash. In fact, this patch totaly breaks the gallery without JS turned on.

So I'm reluctant to commit this to the module, let's try find a cleaner way perhaps?

Anyone has a better idea?

Yes srjosh, that works great, but the gallery doesn't work at all with JS turned off.

OK, I gave this a bit more thought, and it could be implemented, but doing the heavy lifting on the JS side, to keep the gallery working without JS enabled, and the deeplinking without js enabled also working.

Here is an updated patch, basicaly adding the sufix to slide ids with JS instead of in the source markup throug the tpl.

I find it works perfectly on chrome, and on FF also if you open a deeplinked gallery, but, weirdly, in FF if I hit refresh on a gallery page that has a hash in the url, it doesnt show the appropiate image, and shows none. Very weird, can anyone else confirm this? I couldn't track down why.

Testers very welcome!

I'm closing it because the issue was created a long time ago without any further steps.

if you still need it then raise a new one.
thanks