BBCode attempts to cloak email addresses by encoding them in a Javascript code snippet. This breaks the site for users who have Javascript disabled, and should at most be an opt-out feature for site admins who use this module. Without Javascript enabled, the cloaking fails without gracefully degrading, omitting emails without explanation and possibly confusing users.

On a smaller note, the Javascript code uses the deprecated "language" attribute which prevents the site from validating as XHTML. With the type attribute set to text/javascript, the language attribute is redundant and should just be dropped.

Comments

naudefj’s picture

naudefj commented
Assigned: Unassigned » naudefj
Status: Active » Closed (works as designed)

If you don't like the javascript encoding you can disable it. Feel free to provide a patch if you can improve the current implementation.

PS: I will remove the "language" attribute - thanks for the suggestion.