Removing flag for anonymous users returns error: javascript and cookies disabled [#986840]

Hi been pulling my hair trying to get this module to work for anon users for unflagging content.

My set-up is I have a list of content being generated by a view in a page. I also have the default bookmarks view in a block on the same page. Everything works perfectly in firefox but in both IE8 and Safari 4 I can add nodes to my favourites list. When I try and remove them by either clicking the remove link on the page view or block, I get a error of javascript and cookies arent enabled.

When I'm on the bookmarks page the remove faves link works perfectly from both the page and the block.

I have flags 2.0 beta4 and tried with both session api stable and dev.

Anyone got ideas?

Comment	File	Size	Author
#6	js_anon_order.diff	1.02 KB	mooffie

Comments

Comment #1

derjochenmeyer commented 6 December 2010 at 09:03

I have the exact same problem.

Quick Fix: When disabling the Normal Page cache it works.

But we need the caching :-/

Comment #2

derjochenmeyer commented 6 December 2010 at 14:45

Title:

Pulling my hair out removing favourites for anonymous users error javascript and cookies disabled IE8/Safari 4

» Removing favourites for anonymous users returns error: javascript and cookies disabled

I investigated more and found out that "sometimes" the the flag links dont get the ?has_js=1 query string attached.

Without this query string the links return a javascript error.

This Javascript snippet fixes the problem for me (quick & dirty):

Drupal.behaviors.fixFlag = function (context) {
  $('a.flag:not(.fixed-flag)', context).addClass('fixed-flag').each(function() {
    this.href += (this.href.match(/\?/) ? '&' : '?');
    this.href += (this.href.match(/\has_js/) ? '' : 'has_js=1');
  });
};

I use Firefox 3.6.12 on Windows XP

Comment #3

Rene Hostettler commented 7 December 2010 at 00:08

Hi derjochenmeyer

Awesome that fixed it for me! Thanks heaps, have tested it in IE8 and safari 4

Comment #4

mooffie commented 7 December 2010 at 04:57

(Jochen, thank you for finding a solution. I'm currently busy with other Flag issues so I haven't looked into this yet.)

Comment #5

derjochenmeyer commented 7 December 2010 at 08:41

Title:	Removing favourites for anonymous users returns error: javascript and cookies disabled	» Removing flag for anonymous users returns error: javascript and cookies disabled
Priority:	Major	» Critical
Status:	Active	» Needs review

This needs to be fixed at the root. I dont know enough about the inner mechanics of flag to solve the problem, but maybe this helps to trace the bug...

This only happens for me with the normal page cache enabled.

Marking this as critical because it breaks one of the Key features for 2.x branch:

Flagging for anonymous users (even with page caching enabled). Requires Session API.

Comment #6

mooffie commented 8 December 2010 at 21:49

Status	File	Size
new	js_anon_order.diff	1.02 KB

I seem to have found the problem. (And contrary to the OP's report, this bug affects Firefox as well.)

Our JavaScript code currently does these two things, in this order:

It calls Drupal.flagAnonymousLinkTemplates() to add has_js=1 to the links.
It calls Drupal.flagAnonymousLinks() to "[swap] out links with their current state".

The bug is in the order: the addition of has_js=1 is done first, but it immediately gets overwritten by the second step.

The solution is to reverse the order. I'm attaching a patch.