Move background color from body to #page-wrapper

dang it, status...

Failure is real, forgot to add back the default color for text, which coincidentally is the same color used in the test. Good catch color test!

We've had a number of fixes added for the footer/background issue and each one of them has resulted in new issues being created. With the background on BODY we have an issue for many Drupal users (200000+ Drupal sites (over 55%) use an editor), not to mention other uses of iframe loaded documents/widgets etc.

I know HTML and BODY elements are very useful, I suppose it just depends if you care about the rather large amount of users who will be affected by this, the fix is pretty simple really, not sure what the objection is?

We just committed a fix to support Panels, certainly far fewer sites use Panels than use an editor, I didn't see any objections in that issue.

Patch needs a re-roll since another patch was committed. If you want this as the fix to the issue then please do so, I've done my bit here and run out of time for this issue.

Jen - there is a full historical account of all changes made in CVS.

Look in CVS (both for D7 core and Bartik contrib) you can find where the changes were made and use the #issue numbers to look up the relevant discussions.

Heres an alternative, NOT one I am totally happy with but could be a solution - however it special cases for the WYSIWYG module, so if user is not using this module they're shit out of luck... but it does avoid the rather hacky workaround in #3. I will stress again, this is only an idea, need some committer feedback, and if sun is around he might have a better idea...

I think most the objections were from misunderstanding the issue and what we have done over time with regards to the footer and body elements. This is quite understandable, we have messed around this a few times, but inadvertently created new issues in the process. I would love to summarize the changes however I don't have so much time right now.

What I can do is explain what this patch does, blow by blow. Its actually pretty simple stuff and really does fix the issue.

+++ themes/bartik/css/colors.css	3 Jan 2011 20:48:03 -0000
@@ -2,19 +2,15 @@
-body {
-  background-color: #292929;
-  color: #ffffff;
-}
-#page-wrapper,
-#main,
+body,
 body.overlay {
-  background-color: #ffffff;
   color: #3b3b3b;
 }
...
+#page,
+#main-wrapper,

First this switches the body background from #292929 (dark gray) to white. Second it changes the default color for text from white to #3b3b3b (dark gray).

These are the key changes for WYSIWYG editor support and other issues such as the page-top/page-bottom white on white issue.

+++ themes/bartik/css/colors.css	3 Jan 2011 20:48:03 -0000
@@ -45,6 +41,7 @@ a:active {
+#page-wrapper,
 #footer-wrapper {
   background: #292929;
 }

This sets the dark gray background on the #page-wrapper as opposed to the body element - this is for the "expanding sticky footer" emulation. Before we used the body element because it automagically expands to full height of the viewport, and a DIV won't do this normally, so we need the next bit of code...

+++ themes/bartik/css/layout.css	3 Jan 2011 20:48:03 -0000
@@ -2,7 +2,13 @@
+html,
+body,
+#page  {
+  height: 100%;
+}
 #page-wrapper {
+  min-height: 100%;
   min-width: 960px;
 }

This is the key to the #page-wrapper with background color actually working, we trigger 100% height on this element so the background always fills up the whole page - creating the illusion of an "expanding sticky footer".

+++ themes/bartik/css/colors.css	3 Jan 2011 20:48:03 -0000
@@ -2,19 +2,15 @@
+#page,
+#main-wrapper,
 #main-menu-links li a.active,
 #main-menu-links li.active-trail a {
   background: #ffffff;

This adds the white background to the #page and #main-wrapper wrapper divs - the white bit between the header and the footer,

Powered by Dreditor.