covenantd [covenantd]

On a quick review, you may want to validate that the payment amount is numeric in admin_payment_form.
Messages in drupal_set_message() should use the t() function.
I'm not convinced of the necessity to use views_customfield only to create the downpayments link. I suggest you just make a field handler for that.

Otherwise, this looks good and clean. This looks like a great addition to UC.

I did not test it, and won't have time to.

Forgot one thing. You say "we" in the motivation statement, but just to be clear cvs access is granted to individuals, not companies. From your site it looks like you are an individual, so I'm just checking on this.

I am changing status as per previous comments.

I can confirm that CVS accounts are provided to individuals, not companies/organizations; the same is true for drupal.org user accounts.

If you'd like, I could make this project live for you and make you maintainer as soon as your CVS application is approved?

@george@dynapres.nl: You would create the module before it gets approved.

I can create the project on drupal.org for you. Apart from that you need to apply for a CVS account, which has to be approved, which will take some time, after that you can maintain your project via CVS. You can also wait until after the d.o. git migration which will happen in the next couple of months, after which anyone with an d.o. account will have access to the Drupal repository.

Here you go: http://drupal.org/project/uc_downpayment

I thought it was clear a project used for a CVS application cannot be created before it gets approved; it's not up the applicant to decide if the project can be created or not.

@kiamlaluno I'm sorry if I'm acting prematurely here, but there's definitely a demand for this module. There's an enormous backlog in processing for CVS applications (so the CVS application process is completely broken imho) and within a couple of months the git migration will have taken place, with it all d.o. users will have the rights to create projects.

Meanwhile, thumbs up for the uc_downpayment module: clearly a nice piece of work. If a maintainer with enough d.o. access comes along in the next couple of months: approve this application and change the ownership of the module to @coventantd. If not: we'll all head into git territory.

The GIT migration will allow new users to have GIT access when they ask for it, but they will not be able to create new projects.
To create new projects, the project will need to be reviewed in some way.

Since then, a module that is being used for a CVS application cannot be created before it gets approved.
Contrary to what it could seem, it's not just the users that are under review, but also the proposed module/theme; in fact, a CVS maintainer can decline a CVS application because the module duplicate the work done in an already existing project.

@kiamlaluno Thanks for the update.

Here's some background on the module that is currently subject of this application: http://www.ubercart.org/forum/bounties/15764/1000_partial_payment_module

The module works very nice.

Where and when should the "downpayment" information appear ?

at "Home → Administer → Store administration", I get an empty page when just a title : "Partially paid orders"
When Checking out, nothing appends.

Does the user have to be paying by Paypal or can they use credit card/ check too? This sounds like a great module. If we wanted to test should I use the 12/13 attachment?

Just to clarify the new GIT features when the migration goes live: ANY Drupal user will have the ability to create "sandbox" projects, which are stripped down Drupal projects without releases or a short name. This will let them commit code and have an issue queue dedicated to the sandbox for development. When the module is ready to become an official project, it can then be "promoted" into one.

In a related note, I was asked to look at this module as I have developed something similar. I will make a plan to install this module this/next week to go over it.

Every Drupal.org user can create sandboxes; http://drupal.org/documentation/git reports more information.

Hi. Please read all the following and the links provided as this is very important information about your CVS Application:

Drupal.org has moved from CVS to Git! This is a very significant change for the Drupal community and for your application. Please read the following documentation on how this affects and benefits you and the application process:
Migrating from CVS Applications to (Git) Full Project Applications

• The status of this application will be put to "postponed" and by following the instructions in the above link, you will be able to reopen it.
• Or if your application has been "needs work" for more than 5 weeks, your application will be marked as "closed (won't fix)". You can still reopen it, by reading the instructions above.

@covenantd,
+1
This is Arthur here (one of the module $ contributors) ... I sincerely do hope you go through the Git Project Application process for this. It's a great start, that could grow into something, especially if it gets the added momentum of additional contributors.
Best of Luck.

-A