Greetings,
Thank you for the module. I've found it very helpful. I would like to propose you a patch where I fixed 2 issues:
1. A necessity to configure path from code - which is a bad practice.
2. Lack of $GLOBALS['user'] (it is not initialized before login). We found the solution in forums and included it here to achieve a complete version which can be flexibly used.
To fix the first issue I added an ability to the settings page to configure path (static URL or PHP snippet).
To fix the second issue I used 'login_redicrect' menu callback.
Please, consider to include these improvements in HEAD, 5.0 and 4.7 branches.
Thanks a lot!
| Comment | File | Size | Author |
|---|---|---|---|
| #3 | login_destination.patch | 1.7 KB | ardas |
| #2 | login_destination_0.module | 1.78 KB | ardas |
| login_destination.module | 1.75 KB | pokimon |
Comments
Comment #1
ardas commentedHi,
+1
This is exactly what I was going to develop a week ago! :)
Thanks a lot to moshe and pokimon for your work.
Comment #2
ardas commentedI tested this module and found one small issue. There is no second parameter for variable_get() function. Here is a fixed version.
Please review it and give a feedback concerning implemented functionality.
Thanks a lot.
Comment #3
ardas commentedI have created a patch against the latest HEAD revision for easy update (I have slightly reordered function declarations to decrease number of differences).
Here it is.
Comment #4
ardas commentedDone.
Comment #5
(not verified) commented