Which means that untranslated linksto these sizes apear in all languages.
This patch passes them through the localization system.

Although this patch is based on the 4.7 branch, after a brief visual check of the diff, i would say that it 'should' apply to HEAD, too!
Maybe someone can check this, as i don't have a HEAD installation available at the momemt for testing.

Cheers, Danny

CommentFileSizeAuthor
image.module_19.patch2.88 KBdvdweide

Comments

walkah’s picture

walkah commented
Status: Reviewed & tested by the community » Needs review

I'd like some other eyes on this - this seems to do an awful lot of work to get 2 localized labels, no?

dvdweide’s picture

dvdweide commented

I understand your worries, so i'll give a little explanation.

The real problem is not so mutch the translation of two labels, but that these labels are also keywords for choosing the image size.
Because the labels 'thumbnail' and 'preview' are hardcoded in many modules, including 'image' one can't just change them, unless one makes similar patches for all these other modules.
Besides that, if you change the language of the site, or if you use the 'i18n'module and the user chooses another language, your mandatory image sizes would disapear.

So the solution is to have them both, at least for the two hardcoded mandatory sizes.
Still, for 'i18n' users this won't suffice yet. They need a way to configure a multilanguage lables for all image sizes.

Hope that helps a bit!

Cheers, Danny

drewish’s picture

drewish commented
Status: Needs review » Closed (duplicate)

duplicate of http://drupal.org/node/70396