system_tokens() references a not initialized variable [#988878]

The first lines of system_tokens() are the following:

 $url_options = array('absolute' => TRUE);
  if (isset($language)) {
    $url_options['language'] = $language;
  }
$langcode = (isset($language) ? $language->language : NULL);

The variable $language is not a formal parameter of the function (which is an implementation of hook_tokens(), nor is a local variable defined from the function.

As suggested by manimejia, the function is missing the code line

  global $language;

at the beginning.

Comment	File	Size	Author
#6	988878-system-tokens-fix-language-option.patch	2.72 KB	dave reid
#4	global-variable-988878-3.patch	502 bytes	shyamala
#3	global-variable-#988878-3.patch	502 bytes	shyamala

Comments

Comment #1

shyamala commented 16 August 2011 at 05:04

Version:

7.x-dev

» 8.x-dev

Tagging

Comment #2

shyamala commented 16 August 2011 at 05:19

edit tag

Status	File	Size
new	global-variable-#988878-3.patch	502 bytes

Status	File	Size
new	global-variable-988878-3.patch	502 bytes

Comment #5

dave reid

he/him

English

Nebraska USA

commented 16 August 2011 at 16:18

Status:	Active	» Needs work
Issue tags:		+token

The logic of this section is incorrect. We need to duplicate the same logic from the beginning of node_tokens().

  $url_options = array('absolute' => TRUE);
  if (isset($options['language'])) {
    $url_options['language'] = $options['language'];
    $language_code = $options['language']->language;
  }
  else {
    $language_code = NULL;
  }
  $sanitize = !empty($options['sanitize']);

Comment #6

dave reid

he/him

English

Nebraska USA

commented 16 August 2011 at 16:24

Status:

Needs work

» Needs review

Status	File	Size
new	988878-system-tokens-fix-language-option.patch	2.72 KB

Patch against 8.x and 7.x that brings this behavior in line with the rest of the core token functions. No API or parameter changes.

Comment #7

eaton commented 18 August 2011 at 14:09

Status:

Needs review

» Reviewed & tested by the community

This one is kind of a no-brainer. Obvious oversight, subtle repercussions when people try to use multilingual tokens, and an easy fix. I've not tried writing any tests against the language systems, but would it make sense for us to put some together? Hard-code a set of translations, set the locale, and test to ensure the tokens come up in the right language? For the time being the patch works nicely, though.