Closed (fixed)
Project:
http:BL
Version:
7.x-1.0-rc2
Component:
Code
Priority:
Normal
Category:
Task
Assigned:
Reporter:
Created:
4 Dec 2010 at 16:13 UTC
Updated:
17 Aug 2011 at 21:51 UTC
Jump to comment: Most recent file
Title says it all- is a Drupal 7 version of this module in the plans?
| Comment | File | Size | Author |
|---|---|---|---|
| #3 | 989056-3_Drupal7_port.patch | 33.12 KB | deekayen |
| #2 | 989056-2_Drupal7_port.patch | 33.08 KB | deekayen |
Comments
Comment #1
praseodym commentedNo plans, feel free to patch!
Comment #2
deekayen commentedThe attached upgrade represents about 4 hours of work, so I'd appreciate a review or just say I can branch master for 6.x-1.x commit this to master myself.
Some notes:
Comment #3
deekayen commentedThe _httpbl_cache_get() query wasn't complete, so I added the fetchField to return the value as it did in D6.
Comment #4
bryrock commented@deekayen - I know you're patiently awaiting some answers and I have some. Mark (praseodym) is going to set me up as a co-maintainer. So I'm going to get something going for D7 real soon.
I haven't checked out your patches as I've basically done the same thing you have, but I got impatient and jumped ship and created my own fork two years ago and that's what I updated. I've followed this issues queue since Sept. 2009 and my fork's kept up do date with the changes, and also added some of the things that have been languishing forever in this queue in "needs review" status, and now is ready (in production, anyway) in D6 & D7. Right now it's still in a sandbox, but I was working towards releasing it under its own name (honeyblock) and tried as a courtesy to get Mark's blessing. Instead he has suggested co-maintenance on httpbl, so I'll play ball. First thing I had to do is get all the naming changed from honeyblock back to httpbl.
Here's some more info on what I'm porting back to httpbl and also consider improvements… http://drupal.org/sandbox/bryrock/1206968
Once I have the keys to the git repo I'd like to get 7x-dev up ASAP, and also port the fixes and enhancements, where applicable, back to D6 and get an actual release out for that, too.
Comment #5
deekayen commentedIf he said you could be co-maintainer somewhere publicly, I'll go add you (I'm a d.o webmaster when I want to be).
Comment #6
bryrock commentedThanks for the offer but it wasn't public. We've been conversing asynchronously via daily emails over a wide time zone gap. I'm guessing it will happen in another day or two.
Comment #7
bryrock commentedOK. It's not published yet, but I just put up the first 7x.1.x-dev release for httpbl. As always, a dev release has its caveats, but this is based on code I've been running on a production site for two weeks, with no known adversity.
Note: The "controversial" solution to logging in D6 is not required in D7, thanks to API changes that ensure watchdog availability to modules that invoke hook_boot(). So this version includes three levels of optional logging - Quiet, Positive hits only and Verbose (very verbose, mainly only for initial testing and gaining trust).
It also includes some new features that have just been added to an alternate dev fork of D6, namely: View support to expose and report the contents of httpbl's cache table (an alternative to using logs to find out who got blocked and why); and caching periods determined by configurable settings, rather than hard coded values.
Comment #8
bryrock commentedRC 1 released.
Comment #9
RogueM commentedinstalled. will report in a week or so if I note anything odd etc. Thanks for this port, I've been looking for a DNS BL for a while. Hopefully I can stop manually adding IP after painstakingly cross-referencing hosts crawling my site with suspicious patterns now!
Comment #10
bryrock commentedComment #11
RogueM commentedall good here, no complain (related to the module, HoneyPot is another thing).