Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.Task title: Create new preview elements for Style Guide module
Task description:
Background
The Style Guide module for Drupal provides a visual testing page for Drupal themes. Quickly compare the display of common elements across installed Drupal themes, and verify that selected themes addresses all common style elements.
Be sure to use the latest version of HEAD, which incorporates the changes in #949070: Create plugins for Style Guide module [Task 1].
Preparation
-- Download and install Drupal 7.
-- Visit the 'Appearance' page in the administration interface to find the Style Guide links.
New plugins
Using the API (styleguide.api.php, in the module download), create a patch to styleguide.styleguide.inc that adds preview elements only when optional core modules are enabled:
[Task 2: 8 hrs]
-- Forum (4 hrs)
--- theme_forums()
--- theme_forum_form()
--- theme_forum_list()
--- theme_forum_topic_list()
-- Image (4 hrs)
--- theme_image_style(), for all active styles.
-- theme_feed_icon() (1 hr)
Deliverables:
-- Patch(es) to include the desired features to the Style Guide module.
Resources:
Style Guide module: Style guide module
Primary contact:
Estimated time: 8 hours
| Comment | File | Size | Author |
|---|---|---|---|
| #10 | 989060-styleguide-new.patch | 3.85 KB | agentrickard |
| #9 | 989060-styleguide-new.patch | 2.97 KB | agentrickard |
| #7 | 989060.tar_.gz | 1.05 KB | chalet16 |
| #2 | styleguide-gci-task-2.patch | 3.21 KB | chalet16 |
Comments
Comment #1
agentrickardTagging.
Comment #2
chalet16 CreditAttribution: chalet16 commentedThere is no theme guide for theme_forums() because I found that it's only a wrapper for theme_forum_form() and theme_forum_list().
Comment #3
agentrickardOK, I just scanned the list of theme function, so we'll see how you solved that problem.
Comment #4
chalet16 CreditAttribution: chalet16 commentedWhat should I do next?
Comment #5
agentrickardWell, first, we want to move the forum specific functions into a module plugin file. Only core functions really belong in styleguide core.
For this task, the RSS Feed item can stay in styleguide.inc, the others go in forum.inc and image.inc, which handle the 'module_exists' checks for us and autoload the tests.
If you are using the HEAD checkout from CVS, look at how the 'modules' directory is structured. See the reference to #949070: Create plugins for Style Guide module [Task 1], the first task in the list.
Also watch the use of tabs and spacing in the code. There are instances where control statements are not properly formatted, and several tabs where there should be two spaces.
Comment #6
chalet16 CreditAttribution: chalet16 commentedOK, Resubmitted. I need to use a tar file because I can't run "cvs add" with no write access. So I include 1 patch and 2 new file to add instead.
Comment #7
chalet16 CreditAttribution: chalet16 commentedForgot to include patch file.
Comment #8
agentrickardYou want
cvs diff -upNas documented here: http://drupal.org/patch/createBut the tar file is fine, thanks.
Comment #9
agentrickardLike so. The trick is editing the "Entries" file for the CVS folder where the new files are added.
Comment #10
agentrickardExcellent. Note the code cleanup that I did to conform to coding standards. I also added a few inline comments for clarity.
Love the image handling. Do you think we need to do both vertical and horizontal?
Committing this version.
Comment #11
agentrickard