Add support for other aggregation modules

I started looking into this today, and restructured some of the code in the module to try and facilitate it. I couldn't see an obvious way to access the feed data from Leech module, though have posted a feature request for that (or a different way of doing it) at #99193.

Thanks for the interest. I've not had a chance to look into it again yet, but hopefully soon. Which aggregation module are you using? I think Leech and Feedparser are going to be the two that I add support for, unless there are any other modules people are interested in using with GeoRSS.

Thanks - help is always appreciated, especially in testing and picking up on things I may have missed. Suggestions for feature improvements welcome too :)

Just discovered there's a ticket over in the Feedparser queue for this too: http://drupal.org/node/103264

Feedparser support is getting there (see attached patch), but it needs a little patch to Feedparser module and is adding locations with 'xx' as the country currently (more work with location module needed).

It should be working, at least partially... next time you refresh the feed, assuming it's valid (it is important that it's valid) the items should come in with location information added. You'll also need to enable location for the feed aggregator nodes if you hadn't already.

There's no need yet to patch location module (there's a hack in here that makes it work by setting country to 'xx') but I'm hoping to get some time on that and get it working as it should.

Let me know how it goes.

Lucy, that feed is working for me.

Do you get items coming in, but without location information attached to them? Do you get any errors displayed? Have you updated feedparser module recently? If so, have you run update.php as there are changes to the database tables that need to be made by the upgrade script.

When you say you've got location enabled, do you mean the module as a whole, or for that specific node type? In ?q=admin/settings/content-types/aggregator-item I've got the number of locations set to 1 and the rest of the fields set to 'do not collect...'

I've got a patch over in the location module queue now too which should allow us to save location information on incoming feed items once again, without the hack of using 'xx' as the country. I think that gives an end to end information flow again, and with basic testing it does appear to, but I need to sit down and test it all together to make sure.

D'oh - sorry to hear about your wrist! I haven't done any testing with regards to locations on nodes being edited once they've come in, which I think is what you're doing, or even seeing what happens when locations are updated. This starts to get more complex now that there is potentially more than one location on the node but only one on the incoming item.

Am I right in thinking what you want to do is have feed items coming in with the coordinates on them, save that information against the node that's created, and then edit that node into a story which you'd then like to tag with more general locations (countries) in addition to the coordinates that came in originally? That definitely sounds like a use-case I need to support.

I've just applied an updated patch (no need for the country hack now) to the 4.7 branch. If you have the latest version of Feedparser and Location module you can now extract location information from incoming feeds once again.

This patch also makes it work with Aggregator2 again, though foreach errors (related to #114170) are thrown by location module for all feeds. The foreach problem is also present for Feedparser nodes if trying to add nodes from feeds that didn't have location information associated with them (the patch in #114170 fixes that issue).

Still need to look into doing this with Drupal 5.x