Task description:

Background
The Style Guide module for Drupal provides a visual testing page for Drupal themes. Quickly compare the display of common elements across installed Drupal themes, and verify that selected themes addresses all common style elements.

Be sure to use the latest version of HEAD, which incorporates the changes in #949070: Create plugins for Style Guide module [Task 1].

Preparation
-- Download and install Drupal 7.
-- Visit the 'Appearance' page in the administration interface to find the Style Guide links.

New plugins

Using the API (styleguide.api.php, in the module download), create a patch to styleguide.styleguide.inc or a custom module include that adds preview elements only when optional core modules are enabled:

[Task 6: 6 hrs]
-- theme_link() (1 hr)
-- theme_links() (1 hr)
-- theme_mark() (1 hr)
-- theme_menu_link() (1 hr)
-- theme_more_help_link() (1 hr)
-- theme_more_link() (1 hr)

Deliverables:

-- Patch(es) to include the desired features to the Style Guide module.

Resources:

Style Guide module: Style guide module

Primary contact:

agentrickard

Estimated time: 6 hours

Comments

agentrickard’s picture

Issue tags: +gci-research, +gci-hard, +gci-task, +gci-ui

Tagging.

chalet16’s picture

StatusFileSize
new2.67 KB

Patch

agentrickard’s picture

Status: Active » Needs review

First glance is good. Need to test.

agentrickard’s picture

Status: Needs review » Needs work

Mark New, mark Updated, Link, More Help, and More should all have some dummy copy as well, for context.

More Help and More a single paragraph. Updated and New a title (since these are normally shown next to node titles). Link I'm not sure about. Is the context here the links at the end of a node?

Note also that you use $current_path in most cases, but a stray request_path() in line 48 of the patch.

The Menu link also looks to replicate the existing Menu Tree function. I was hoping we could isolate a single menu item, but that might not be possible. If not, we can remove that, and possibly move the existing function into the new Links group.

chalet16’s picture

StatusFileSize
new3.29 KB

Update

agentrickard’s picture

Status: Needs work » Fixed
StatusFileSize
new3.58 KB

Nice. I moved the menu link to the Menus group, changed one 'false' to 'FALSE' and added a comma to the last item of an array.

Committed and approved.

Status: Fixed » Closed (fixed)
Issue tags: -gci-research, -gci-hard, -gci-task, -gci-ui

Automatically closed -- issue fixed for 2 weeks with no activity.