Initial patch for Drupal 5.0
jrt - November 21, 2006 - 22:24
| Project: | Filemanager |
| Version: | HEAD |
| Component: | Code |
| Category: | task |
| Priority: | normal |
| Assigned: | Unassigned |
| Status: | closed |
Description
Mostly untested, but at least the module loads and the settings seem to work as expected.
| Attachment | Size |
|---|---|
| filemanager_patch.tar.gz | 1.38 KB |
#1
please don't post conpressed files. if you can't roll the .info file in the patch, post it as a comment to the issue.
#2
OK, here is the patch in pure, unadulterated plain text format.
#3
looks pretty good. could you not move the functions (like filemanager_menu()) around though? it makes it harder to view the changes you're making. i'd be into re-organizing stuff after this gets comitted.
#4
http://drupal.org/node/103632 was marked as a duplicate of this.
#5
Nice a patch for 5.x
but i can´t find the places in the file to change. can everyone post the complete file to copy and paste?
thx
caot
#6
It does not work for me.
i applied the patch and copied the module to my drupal installation, but it is not detected.
#7
gmeier: Did you copy the filemanager.info file as well?
#8
The patch + .info file. Look alright to me. The module is detected and turned on.
#9
I don't know how to apply patches. Is this in the HEAD version?
#10
http://drupal.org/node/60108
#11
How about getting this one commited so that less able users can readily take advantage of it to update their 4.7 instalations?
#12
Here's a complete patch for 5.1. Tested by itself as much as possible, will test further when I finish updating the Attachment module.
#13
in the .install file i don't think it's worth the trouble to check
if( ! db_table_exists('file') )the way it's done in core is just assume it doesn't exists, if it does you'll just get an error but not loose any data. also the drupal coding standards say you shouldn't put spaces at the beginning and end of the function calls.the .info file looks good.
the changes to the .module file look good.
so i'm going to add the .info file and commit the changes to the .module. if you want to roll a subsequent patch for the .install file i'll review that. also adding you to the CREDITS file ;)
#14