Mostly untested, but at least the module loads and the settings seem to work as expected.

CommentFileSizeAuthor
#12 filemanager-5.x-1.x-dev.patch6.23 KBcscsteve
#2 filemanager_2.patch5.77 KBjrt-1
filemanager_patch.tar.gz1.38 KBjrt-1

Comments

drewish’s picture

drewish commented
Status: Needs review » Needs work

please don't post conpressed files. if you can't roll the .info file in the patch, post it as a comment to the issue.

jrt-1’s picture

jrt-1 commented
StatusFileSize
new filemanager_2.patch5.77 KB

OK, here is the patch in pure, unadulterated plain text format.

drewish’s picture

drewish commented

looks pretty good. could you not move the functions (like filemanager_menu()) around though? it makes it harder to view the changes you're making. i'd be into re-organizing stuff after this gets comitted.

drewish’s picture

drewish commented

http://drupal.org/node/103632 was marked as a duplicate of this.

caot’s picture

caot commented

Nice a patch for 5.x
but i can´t find the places in the file to change. can everyone post the complete file to copy and paste?

thx

caot

gmeier’s picture

gmeier commented

It does not work for me.
i applied the patch and copied the module to my drupal installation, but it is not detected.

jrt-1’s picture

jrt-1 commented

gmeier: Did you copy the filemanager.info file as well?

ricmadeira’s picture

ricmadeira commented

The patch + .info file. Look alright to me. The module is detected and turned on.

nancydru’s picture

nancydru
she/her/hers
Primary language English
Location Boston
commented

I don't know how to apply patches. Is this in the HEAD version?

vhmauery’s picture

vhmauery commented

http://drupal.org/node/60108

ricmadeira’s picture

ricmadeira commented

How about getting this one commited so that less able users can readily take advantage of it to update their 4.7 instalations?

cscsteve’s picture

cscsteve commented
Status: Needs work » Needs review
StatusFileSize
new filemanager-5.x-1.x-dev.patch6.23 KB

Here's a complete patch for 5.1. Tested by itself as much as possible, will test further when I finish updating the Attachment module.

drewish’s picture

drewish commented
Status: Needs review » Fixed

in the .install file i don't think it's worth the trouble to check if( ! db_table_exists('file') ) the way it's done in core is just assume it doesn't exists, if it does you'll just get an error but not loose any data. also the drupal coding standards say you shouldn't put spaces at the beginning and end of the function calls.

the .info file looks good.

the changes to the .module file look good.

so i'm going to add the .info file and commit the changes to the .module. if you want to roll a subsequent patch for the .install file i'll review that. also adding you to the CREDITS file ;)

Anonymous’s picture

(not verified) commented
Status: Fixed » Closed (fixed)