Initial patch for Drupal 5.0 [#99016]

Comment	File	Size	Author
#12	filemanager-5.x-1.x-dev.patch	6.23 KB	cscsteve
#2	filemanager_2.patch	5.77 KB	jrt-1
	filemanager_patch.tar.gz	1.38 KB	jrt-1

Comment #1

drewish CreditAttribution: drewish commented 21 November 2006 at 23:13

Status:

Needs review

» Needs work

please don't post conpressed files. if you can't roll the .info file in the patch, post it as a comment to the issue.

Log in or register to post comments

Comment #2

jrt-1 CreditAttribution: jrt-1 commented 22 November 2006 at 03:49

File	Size
filemanager_2.patch	5.77 KB

OK, here is the patch in pure, unadulterated plain text format.

Log in or register to post comments

Comment #3

drewish CreditAttribution: drewish commented 11 December 2006 at 17:18

looks pretty good. could you not move the functions (like filemanager_menu()) around though? it makes it harder to view the changes you're making. i'd be into re-organizing stuff after this gets comitted.

Log in or register to post comments

Comment #4

drewish CreditAttribution: drewish commented 2 January 2007 at 23:22

http://drupal.org/node/103632 was marked as a duplicate of this.

Log in or register to post comments

Comment #5

caot CreditAttribution: caot commented 3 February 2007 at 00:17

Nice a patch for 5.x
but i can´t find the places in the file to change. can everyone post the complete file to copy and paste?

thx

caot

Log in or register to post comments

Comment #6

gmeier CreditAttribution: gmeier commented 22 February 2007 at 09:34

It does not work for me.
i applied the patch and copied the module to my drupal installation, but it is not detected.

Log in or register to post comments

Comment #7

jrt-1 CreditAttribution: jrt-1 commented 23 February 2007 at 20:02

gmeier: Did you copy the filemanager.info file as well?

Log in or register to post comments

Comment #8

ricmadeira CreditAttribution: ricmadeira commented 28 February 2007 at 17:43

The patch + .info file. Look alright to me. The module is detected and turned on.

Log in or register to post comments

Comment #9

NancyDru

she/her/hers

English

Boston

CreditAttribution: NancyDru commented 15 March 2007 at 02:49

I don't know how to apply patches. Is this in the HEAD version?

Log in or register to post comments

Comment #10

vhmauery CreditAttribution: vhmauery commented 16 March 2007 at 13:53

http://drupal.org/node/60108

Log in or register to post comments

Comment #11

ricmadeira CreditAttribution: ricmadeira commented 30 April 2007 at 03:08

How about getting this one commited so that less able users can readily take advantage of it to update their 4.7 instalations?

Log in or register to post comments

Comment #12

cscsteve CreditAttribution: cscsteve commented 15 June 2007 at 17:41

Status:

Needs work

» Needs review

File	Size
filemanager-5.x-1.x-dev.patch	6.23 KB

Here's a complete patch for 5.1. Tested by itself as much as possible, will test further when I finish updating the Attachment module.

Log in or register to post comments

Comment #13

drewish CreditAttribution: drewish commented 5 July 2007 at 04:44

Status:

Needs review

» Fixed

in the .install file i don't think it's worth the trouble to check if( ! db_table_exists('file') ) the way it's done in core is just assume it doesn't exists, if it does you'll just get an error but not loose any data. also the drupal coding standards say you shouldn't put spaces at the beginning and end of the function calls.

the .info file looks good.

the changes to the .module file look good.

so i'm going to add the .info file and commit the changes to the .module. if you want to roll a subsequent patch for the .install file i'll review that. also adding you to the CREDITS file ;)