Closed (fixed)
Project:
Drupal core
Version:
5.x-dev
Component:
user system
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
22 Nov 2006 at 00:19 UTC
Updated:
6 Dec 2006 at 13:15 UTC
Jump to comment: Most recent file
Comments
Comment #1
RobRoy commentedGood idea. But we shouldn't pass that translated link to t() again as any translated elements in that will get re-translated. I'd either move it after the end of the t() call or include it as a %password-link for example.
Comment #2
gregglesthanks RobRoy - for posterity, webchick had the same advice.
Here is an updated patch that includes that advice AND (as a bonus) fixes a situation earlier in the module where we had two calls to t() on the same line. Using this patch translators will get more context about what they are translating.
Comment #3
RobRoy commentedGood enough for me.
Comment #4
webchickLooks good! This patch is exactly the same, but removes an extra space between the . and the <a href because I'm just picky that way. ;)
Marking RTBC since a few of us have looked at it now.
Comment #5
dries commentedCommitted to CVS HEAD.
This is not a critical issue, folks!
Comment #6
gregglesSorry, Dries. The critical status was my fault. I was just following the protocol of the other string freeze issues to get them in before the RC (as Webchick laid out in her mail on the subject to the devel list).
Either way - thanks for committing it :)
Comment #7
(not verified) commented