Closed (fixed)
Project:
Killfile
Version:
6.x-1.x-dev
Component:
Code
Priority:
Major
Category:
Feature request
Assigned:
Reporter:
Created:
6 Dec 2010 at 19:26 UTC
Updated:
25 Feb 2011 at 16:11 UTC
I have rewritten this module to work on drupal 7, but I have a few changes from the original.
The differences are:
1) Instead of implementing own functionality for a few things, use existing well supported modules
- this means rules integration
- this means views integration
2) Removed feeds support.
- I am thinking feeds support could be implemented via the rules system, if not let me know if people want that support back
3) Now requires the following module that I wrote: http://drupal.org/project/cf
4) There now is an undelete process
5) Permanent delete must always be manually selected
6) A few more permissions to break down who can delete, undelete, and permanently delete nodes.
7) The module is now called "soft delete" to sound more "friendly" than killfile
- I am not sure if i have to start a new module or not to get a new name, so I am posting here first.
The new module is attached.
If you have a problem with the ck module support, post a bug report there and reference this.
| Comment | File | Size | Author |
|---|---|---|---|
| soft_delete.tar_.gz | 8.5 KB | thekevinday |
Comments
Comment #1
Arto commentedThe features you outline sound good in principle.
The killfile feeds were being used to propagate deletes from one site to another in a large-scale distributed publish/subscribe network of Drupal sites, but I have not heard whether that project is going to eventually upgrade to D7 or not, so it's probably not a priority for anyone just this moment.
As I commented in #990690: Offering to maintain Drupal 7 version of Killfile, I do not support renaming the project. In my own experience, of the Drupal modules I've founded those that have found the greatest success and widespread uptake (including most significantly Drush and Boost) have had distinguishing, non-bland naming more often than generic names with no personality, identity, or memorability. This has clearly helped differentiate them from otherwise similar alternative modules.
However, if even taking the previous into account you do wish to still proceed with the rename, I am not going to stand in the way since I'm unlikely to personally put further effort into this project given that I don't do much Drupal development any longer.
To rename the project, you would have to submit a webmaster issue to the Drupal.org administrators. I've previously renamed a project or two; note that the CVS part of the rename process is yucky: there is no way to permanently remove the old name in CVS, so the directories involved will stick around forever. Also, renaming a project kills any links to the old project URL(s), which will just return a 404 Not Found (no automatic redirects are provided).
Comment #2
thekevinday commentedI have renamed soft_delete back to killfile.
I just noticed that I overlooked RDF support and given that it has a drupal 7 module, then I will have to look in adding drupal 7 rdf support.
Edit:
The reason why I think feeds may not need to be directly supported is that I am provided "On killfile" events to the rules module.
Then the rules module can react on these killfile events and send the information to whomever.
This may be do-able with RDF as well, but I need to read up on the RDF module first.
What I might do is provide either a documentation example or a pre-built rules event that shows how a feed might be sent out on a killfile event.
Comment #3
Arto commentedAll right, that makes sense; the Rules integration is probably the way to go.
Comment #4
thekevinday commentedI have now looked into the details of the feeds module and now understand what you are trying to do.
The basics can be done with rules, but the details probably need to be handled with explicit feeds support.
For example, I noticed that they have a "node expires on" select list for the node processor.
I also noticed you had a TODO about this in your code.
I will be putting the feeds support back into the killfile module for drupal 7 and will also look into the doing the RDF as well (if necessary).
Comment #5
thekevinday commentedThe killfile.rdf path now exists and provides the rdf+rss feed.
This should allow for the transition from drupal 6 to drupal 7 to work.