the users table for Drupal has 3 timestamp fields for account creation date, last access, and last login date. Right now this module only imports that phpbb2 registration date.

I added the two additional array parameters below to the user array starting on line 1079

'access' => $user->user_lastvisit,
'login' => $user->user_lastvisit,

CommentFileSizeAuthor
#2 user_session_lastvisit.diff.txt1.27 KBbeginner

Comments

beginner’s picture

beginner commented

Can you provide a patch on the latest HEAD? Thanks.

beginner’s picture

beginner commented
Status: Active » Needs review
StatusFileSize
new user_session_lastvisit.diff.txt1.27 KB

Can someone test this patch?

Added:
phpbb->user_lastvisit => drupal->login
phpbb->user_session_time => drupal->access

P.S. @jaydub: greetings from the other China, the Republic of China. :)

neclimdul’s picture

neclimdul
He/Him
commented
Status: Needs review » Reviewed & tested by the community

Works for me. Looks simple enough. RTBC.

beginner’s picture

beginner commented
Status: Reviewed & tested by the community » Fixed

Thanks for taking the time to have a look.
I committed the patch.
Did you actually test it? If not, next time you do a test import of phpBB, please do check in the drupal DB that the fields have been imported as intended.

Thanks for your contributions. :)

beginner’s picture

beginner commented

btw, with this patch, it seems that the most important has already been fixed.
If you want to roll a patch to upgrade to Drupal 5 next, I'd be happy to have a look at it, unless you want to add a couple of features in the current branch first.

neclimdul’s picture

neclimdul
He/Him
commented

Yeah, tested and worked just fine. I'm on the 5 patch next. :)

Anonymous’s picture

(not verified) commented
Status: Fixed » Closed (fixed)