Somehow this theme is leaving some erroneous text in the content-header. This is a fresh install, no new modules. Drupal 7 rc1

See source snip. Pasted exactly as is with all the whitepace then "Array"

<div id="content-header"> 
 
            
            
                          <h1 class="title">Welcome to Test Site</h1> 
            
                         
            Array
          </div> <!-- /#content-header -->

Have had a dg through and can't for the life of me figure it out. Does the same using the dev version. Erroneous text disappears if change to another theme.

Cheers,
Sam

CommentFileSizeAuthor
#2 basic-7.x-2.x-dev-basic_menu_local_tasks.patch1.5 KBbalazs.hegedus

Comments

Argus’s picture

Argus commented

yup confirming this

balazs.hegedus’s picture

balazs.hegedus commented
Title: Adding random text in content-header » Local tasks not being rendered
Version: 7.x-2.0-rc2 » 7.x-2.x-dev
Status: Active » Needs review
StatusFileSize
new basic-7.x-2.x-dev-basic_menu_local_tasks.patch1.5 KB

Hi,

here's a patch to fix this issue for the dev version. Marking as needs review as I'm not entirely familiar with the theming layer in D7 and what are the implications of the changes I've made.

Also changing the issue title to reflect what the problem is.

This patch changes basic_menu_local_tasks() in template.php. According to the original source the function supposed to be a duplicate of theme_menu_local_tasks(), yet it returned an array instead of a string. The function is now a duplicate of theme_menu_local_tasks(), producing the intended output.

psicomante’s picture

psicomante commented

It works perfectly. Remember render($tabs) in page.tpl.php (i changed it to $tabs, but it prints Array - don't know why)

fietserwin’s picture

fietserwin
Location Le Mont-Dore
commented
Status: Needs review » Reviewed & tested by the community

#2 works here as well. Ignored #3: $tabs is still an array that needs to be rendered (by basic_menu_local_tasks()).

fietserwin’s picture

fietserwin
Location Le Mont-Dore
commented
Status: Reviewed & tested by the community » Needs work

That said, the current and patched version of basic_menu_local_tasks() as an override of theme_menu_local_tasks() introduce an error against accessibility guidelines, see a.o. http://drupal.org/update/theme/6/7#theme-links-param and #364219: Navigation menus should be preceded by headings of the appropriate level (usually <h2>)..

Better to patch that as well, or in other words, copy the theme_menu_local_tasks() function again and add the classes (with-secondary and clearfix) as needed.

Sinan Erdem’s picture

Sinan Erdem commented

subscribe

gapa’s picture

gapa commented

For #3 I made a patch in http://drupal.org/node/1029730. Is it ok?

SteveK’s picture

SteveK commented
Assigned: Unassigned » SteveK
Status: Needs work » Fixed

I've committed a fix to the dev release. thanks!

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.