drupal_array_get_nested_value() has all it takes to actually return a reference, except the function signature.

Could we change that, please?

CommentFileSizeAuthor
#4 991066-drupal_array_get_nested_value-reference.patch1.01 KBdamien tournoud
#1 991066-drupal_array_get_nested_value-reference.patch784 bytesdamien tournoud

Comments

damien tournoud’s picture

damien tournoud commented
Status: Active » Needs review
StatusFileSize
new 991066-drupal_array_get_nested_value-reference.patch784 bytes

Thanks!

chx’s picture

chx commented
Status: Needs review » Reviewed & tested by the community

The mustache theme engine basically needed a copy of this function to be able to receive a reference. So apparently this is needed. Existing code is not broken. $a = drupal_get_nested_value it wont matter but it allows $a = &drupal_get_nested_value

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 991066-drupal_array_get_nested_value-reference.patch, failed testing.

damien tournoud’s picture

damien tournoud commented
Status: Needs work » Needs review
StatusFileSize
new 991066-drupal_array_get_nested_value-reference.patch1.01 KB

Ew.

casey’s picture

casey commented

#4: 991066-drupal_array_get_nested_value-reference.patch queued for re-testing.

casey’s picture

casey commented
Version: 7.x-dev » 8.x-dev

oops, does this work?

casey’s picture

casey commented
Version: 8.x-dev » 7.x-dev

Fixed in D8, backport?

chx’s picture

chx commented

#4: 991066-drupal_array_get_nested_value-reference.patch queued for re-testing.

Status: Needs review » Needs work

The last submitted patch, 991066-drupal_array_get_nested_value-reference.patch, failed testing.

joelpittet’s picture

joelpittet
he/him
Primary language English
Location Vancouver
commented
Issue summary: View changes
Status: Needs work » Closed (duplicate)

This looks to be resolved by this commit #635046: form_state_values_clean() is polluting form values (followup)