Installing an in-code input format with the same name as an existing in-database input format produces SQL errors:

Duplicate entry 'Filtered HTML' for key 2 query: INSERT INTO ho4p_filter_formats (name) VALUES ('Filtered HTML') in /var/www/drupal/sites/all/modules/input_formats/input_formats.module on line 515.
Duplicate entry 'Filtered HTML' for key 2 query: UPDATE ho4p_filter_formats SET cache = 1, name='Filtered HTML', roles = ',1,2,' WHERE format = 3 in /var/www/drupal/sites/all/modules/input_formats/input_formats.module on line 535.

It also messes up database records for another existing in-database input format. This is because "name" is primary key on "filter_formats" table, and input_formats_save() does not check for errors when insering there on line 515. When a duplicate insert is attempted, then $input_format->format is set incorrectly in the next code line, and subsequent code in input_formats_save() goes on to update that wrong format, effectively messing it up completely.

Attached a patch (against CVS HEAD). The new code, upon finding an in-database format with the same name, updates it instead of trying to create a new format. I'm not sure if this is ideal behaviour, but at least it seems better than the current one.

CommentFileSizeAuthor
#4 input_formats-duplicate-entry-991344-4.patch1.28 KBscottrigby
#5 input_formats-duplicate-entry-991344-5.patch1.31 KBscottrigby
input_formats-duplicates.patch1.06 KBahtih

Comments

hiddentao’s picture

hiddentao commented

Am having this same problem. +1.

I'm using Input Formats with Exportables and the Exportables table gets corrupted because all the filter formats end up having the same ids in it.

andrew_mallis’s picture

andrew_mallis commented

Also had this problem. We want to control the allowd html allowed tags.

The patch above made the error go away, but does not insert our new values anywhere in this input format/

davidtrainer’s picture

davidtrainer commented

subscribing.

scottrigby’s picture

scottrigby
he/him
Primary language English
Location Brooklyn, NY
commented
StatusFileSize
new input_formats-duplicate-entry-991344-4.patch1.28 KB

Rewrote this a bit
git-formatted patch against 6.x-1.x (assuming that's where development is happening apart from the api?)

Edit: Use #5 instead

scottrigby’s picture

scottrigby
he/him
Primary language English
Location Brooklyn, NY
commented
StatusFileSize
new input_formats-duplicate-entry-991344-5.patch1.31 KB

Revised. It's be great to get someone to test this on a fresh install.

dagmar’s picture

dagmar
Primary language Spanish
Location Argentina
commented

Thanks for working on this. I will commit this if you say that works. However I have a question:

What happens with "The patch above made the error go away, but does not insert our new values anywhere in this input format/" mentioned in #2?

scottrigby’s picture

scottrigby
he/him
Primary language English
Location Brooklyn, NY
commented

hi dagmar - I rewrote the query to do exactly what the original part of this function does (insert a record so we can get the numeric format id), except it checks to make sure that format isn't already there before trying to insert it.

Rather than a single query like #1, I used a few more lines but made it more readable, and also should be DB-type-agnostic. So I don't think #2 will be an issue here

ZenDoodles’s picture

ZenDoodles commented
Status: Needs review » Reviewed & tested by the community

/me waves at scottrigby

I have reviewed and tested this patch (although not on a fresh install yet). It looks good to me.

c4rl’s picture

c4rl commented
Issue summary: View changes

Bump! There it is.

This project need a new maintainer? #D6forlife.