Closed (fixed)
Project:
Sweaver
Version:
7.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
7 Dec 2010 at 16:27 UTC
Updated:
24 Aug 2011 at 00:20 UTC
Drupal 7rc1
Sweaver 7.x-1.x-dev (current)
Colorbox 7.x-1.x-dev (current)
Steps to replicate the issue:
* Login as user 1
* add image field to any content type
* configure image field to use Colorbox formatter
* create node with image
* try to click on image
Expected result: Colorbox activated
Current result: No colorbox window - user is redirected to image file
After unloging or switching to user who cannot use Sweaver UI the problem don't occur. Disabling Sweaver module also helps.
Comments
Comment #1
swentel commentedComing from #1006376: Doesnt seems to work. Use this issue to list modules which breaks either the module or sweaver. Colorbox seems one of them. Give us steps how to reproduce the problem, like the start of this original issue.
Comment #2
alexkessler commentedIncompatible with overlay module.
Setup:
Drupal 7 Beta3
Sweaver 7.x-1.x-dev
Ctools 7.x-1.x-dev
If sweaver is enabled, overlay stops working. Deactivating sweaver brings the overlay back.
This also happens on paths where sweaver is not active like admin/*.
Comment #3
mshepherd commentedConfirming that sweaver 7.x-1.1 breaks the overlay in Drupal 7.
Drupal Core 7.0
Chaos tool 7.x-1.0-alpha2
Fresh install with only Core, Ctools and Sweaver running.
Comment #4
mcaden commentedSuperfish: The menu doesn't drop down at all if the sweaver editor is enabled.
Media: Inserting menu items when the sweaver editor is enabled causes sweaver to dock at the bottom of the dialog used to insert media.
Comment #5
mcaden commentedI noticed #1043336: Disable sweaver on wysiwyg_imageupload iframe and decided to apply it to the Media module and it worked perfectly. Can we please get 'media/*' included in the default excluded pages?
Comment #6
mcaden commentedI've looked into a couple of the issues and both of these seem to reside in sweaver_plugin_editor.js:
Overlay - The overlay is attached to the object via javascript. Sweaver is adding its own click event to the object, then stopping event propagation. What about taking the click events of the source object and copying them to the sweaver "Click here to follow" object?
Superfish - This problem is due to the selection preview - disabling it causes the problem to go away. I would guess this has to do with hijacking and stopping events but I don't see exactly where.
Comment #7
jeremyll commentedMediaelement.js: This also breaking the play button in mediaelement.js players
Comment #8
jyve commentedHi,
the click handling mechanism has been reworked a bit in the D7 dev version so that it nog longer breaks the overlay module. This solution should also solve the issues with other modules. If you have an link that Sweaver breaks, simply add the selector to the 'excluded selectors' and Sweaver will no longer interfere.
The exception to this is the colorbox module. It doesn't seem possible to make sure the links still work and still have support the extra click events. So for now, I have chosen to make the link work.
Comment #9
mshepherd commentedThanks! Overlay now working again with the 7th March dev release.
Comment #10
ryantboyd commentedYeah, my install of Sweaver is not working like this too. Sorry, I dont understand here..... what is the solution?
Comment #11
ryantboyd commentedSorry, follow up, disable Colorbox and it seems to work. But I need colorbox, so no Sweaver for me for now. really cool module though.... so this is the issue then?
Comment #12
mshepherd commentedperhaps you could confirm to the developer that you've installed the most recent dev release...
Comment #14
vito_swat commentedI need to reopen the issue.
I'm using d7 7.0, current devs of ctools and sweaver.
My admin bar at top of the page is unstylled when sweaver editor is enabled. So the issue still occur.
Comment #15
vito_swat commentedI narrowed the issue. This only occur when you aggregate css files and use the grey theme of sweaver. Looks like the grey.css file i not properly finished. Lack of "}" at the end of file is causing this. easy to fix.
BTW. I also find mistake in both styles css. Around line 500-510 there is word "imporant" instead of "important"
Comment #16
paulgemini commentedI can also report that disabling Colorbox gets it working. I'm running the latest Colorbox 7.1-1.x-dev.
Comment #17
karens commentedThe bug in #15, a missing bracket in the grey skin css, is also present in the D6 version. In the D6 version it keeps the colorpicker from appearing. The invalid css is very possibly the source of some of these other problems.
Comment #18
jyve commentedThe issue in #15 has been fixed and commited to the dev version. Since I cannot reproduce the issue, can you please check if this solves your problems?
Comment #19
jyve commentedComment #20
vito_swat commentedChecked and sill not working. During the commit: "Fix for #1168468: background position error" the bug in grey.css was reintroduced.
Comment #21
instanceofjamie commentedI've just checked this using 7.x-1.x-dev, and it appears to work. If sweaver is open, I get the element select options with an additional option to follow the link. If not, I get the colorbox. Marking as needs review, but I think this specific issue is fixed. If noone else reviews it inside a couple of weeks and finds anything different, I'll mark as done.
Comment #22
instanceofjamie commentedComment #23
vito_swat commentedOn june 12 the closing bracket was back. It works now.
Comment #24
vm commentedComment #25
instanceofjamie commentedComment #26
cosmodrom commentedThanks for that ! :)