It would be a great benefit to use Microformats for the address output.

I think that the hcard-Microformat or the geo-Microformat fits.

What do you think about this?

CommentFileSizeAuthor
#18 location_microformat_vcard.patch_4.txt6.93 KBTobias Maier
#11 location_microformat_vcard.patch_3.txt7.22 KBTobias Maier
#10 location_microformat_vcard.patch_2.txt7.2 KBTobias Maier
#8 location.inc-vcard-geo.patch.txt3.35 KBsillygwailo
#7 location_microformat_vcard.patch_1.txt6.32 KBTobias Maier
#3 location_microformat_vcard.patch_0.txt43.31 KBTobias Maier
#1 location_microformat_vcard.patch.txt43.29 KBTobias Maier

Comments

Tobias Maier’s picture

Tobias Maier commented
Title: Investigate using Microformat for adress output » Using Microformat for address output
Version: 6.x-3.x-dev » 4.7.x-1.x-dev
Status: Active » Needs review
StatusFileSize
new location_microformat_vcard.patch.txt43.29 KB

here comes the first patch for this.

Changes:

  1. using hcard-Microformat at theme_location() and theme_location_de()
    One issue/question: What should we do (which hcard-class) with $location['name']? We can't say if it is the organization or the name of a person or anything else...
  2. removed ?> at the end of location.inc and location.de.inc
  3. removed white space at the end of lines
Tobias Maier’s picture

Tobias Maier commented

I forgot to mention that I added the $hide argument for functions like theme_location_de()...

btw. it seems like that this function can't be overwritten (like every other theme-function)

Tobias Maier’s picture

Tobias Maier commented
StatusFileSize
new location_microformat_vcard.patch_0.txt43.31 KB

since the class "fn" is required I added this one to $location['name']

Tobias Maier’s picture

Tobias Maier commented

Here is an example you can find on one of my sites:
standorte/waschsalon-albertrosshaupterstrasse-munchen

btw. I like the Tails extension for Firefox 2.0 to view and export microformats from websites.

m3avrck’s picture

m3avrck commented

This patch looks much bigger than it should, I'm guessing it's a line ending problem, either unix or windows based.

Not sure if location module had it wrong or your patch but be good to double check that :-)

Tobias Maier’s picture

Tobias Maier commented
Status: Needs review » Needs work

it is so big, because I removed blanks in the end of lines...
They were so much so that this patch got far too big...
I putted this in an own patch: http://drupal.org/node/100830
it is really not an important patch, but the code looks cleaner IMHO...

Tobias Maier’s picture

Tobias Maier commented
Status: Needs work » Needs review
StatusFileSize
new location_microformat_vcard.patch_1.txt6.32 KB

I hope this patch works...

is clean now..

sillygwailo’s picture

sillygwailo
Location Toronto, ON
commented
StatusFileSize
new location.inc-vcard-geo.patch.txt3.35 KB

Building on the patches above, I added http://microformats.org/wiki/geo support. My patch definitely needs review because a) I applied the above patches manually and ended up moving around some curly braces (some possibly in the wrong spot).

ankur’s picture

ankur commented

Oh man. I gotta learn about microformats and geo-microformats before I can even test these patches? Any volunteers? I'm curious myself, but can't expense the time at the moment.

Taking a quick look at the microformat classes, I'm anxious to get both 'geo' and 'adr' class support.

Richard, if you're not sure your braces are in the right places, would you mind testing it and seeing if it works and outputs the appropriate HTML?

Tobias, would you be willing to a look if you get a chance. I would like to commit a verifiedly working version of this patch soon.

-Ankur

Tobias Maier’s picture

Tobias Maier commented
StatusFileSize
new location_microformat_vcard.patch_2.txt7.2 KB

I added Richards' patch to my one and made it translatable

You can see it live at
http://www.muenchner-waschsalon.de/standorte/waschsalon-aidenbachstrasse...

But to be honest: I dont like the way lat/lon gets presented to the end user.
my second thought is that I dont even know if we should bother the end-user with such specific data like this...

Tobias Maier’s picture

Tobias Maier commented
StatusFileSize
new location_microformat_vcard.patch_3.txt7.22 KB

oh sorry
I tried a new editor which added a few new tabulators instead of two blanks.
here comes the corrected patch

Tobias Maier’s picture

Tobias Maier commented

Hello Ankur,

whats your opinion about this?
Personally I prefer the version without lat/lon (#7).

ankur’s picture

ankur commented

Yeah, it would probably look aesthetically displeasing to have the lat/lon displayed for every address that has a pair figured out. Perhaps we can make it something configurable? or leave it up to the themer if the themer chooses to replace the theming function with one of their own.

Will update the patch so that it is configurable.

In the meantime, do microformats support fields that can be a part of a microformatting, but somehow hidden and parseable by something that collects microformat data?

m3avrck’s picture

m3avrck commented

Sure, you could hide the microformat text using CSS.

Would be a technique similar to one of these: http://www.mezzoblue.com/tests/revised-image-replacement/

That would probably be the best be to comply fully with the microformat, no?

m3avrck’s picture

m3avrck commented

For reference, this is exactly what Flickr does as evidenced here:

<div style="position: absolute; right:7px; bottom:7px; font-family: Arial; font-size: 11px; color: #999"><i>40&#176;24' 54" N, 3&#176;41' 57" W<span class='geo' style='display:none'><span class='latitude'>40.414933</span><span class='longitude'>-3.699259</span></span></i></div>
Tobias Maier’s picture

Tobias Maier commented

the right way to do the same what flickr does is

<span class='geo'><abbr class='latitude' title="40.414933">40°24' 54" N</abbr>, <abbr class='longitude' title="-3.699259">3°41' 57" W</abbr></span>

and if you want to never show it then this should be right

<span class='geo'><abbr class='latitude' title="40.414933" /><abbr class='longitude' title="-3.699259" /></span>

see point 5 of http://microformats.org/wiki/hcard#Semantic_XHTML_Design_Principles

m3avrck’s picture

m3avrck commented
Status: Needs review » Needs work

Tobias, right on.

And we should *not* hardcode display:none, that should go into the CSS file.

Just wanted to illustrate the point that we can use the full geo format and CSS to hide what we don't need, just like Flickr. That way people can use CSS to turn on and off what they don't want.

Seems like that solves this issue -- time for an updated patch?

Tobias Maier’s picture

Tobias Maier commented
Status: Needs work » Needs review
StatusFileSize
new location_microformat_vcard.patch_4.txt6.93 KB

allright, here it is

it uses <abbr /> to hide latitude and longitude in general

geodaniel’s picture

geodaniel commented

+1

Haven't tested the patch yet, but I like the idea of adding microformats for the addresses, and it fixes #109954 as well, which didn't close the tags properly in the .de include.

ankur’s picture

ankur commented
Status: Needs review » Fixed

Applied to DRUPAL-4-7 and DRUPAL-5

pancho’s picture

pancho
Location UTC+2 🇪🇺 EU
commented

subscribing

ankur’s picture

ankur commented

Pancho, you're subscribing to an issue that's been marked fixed? Did the application of this patch break something?

Anonymous’s picture

(not verified) commented
Status: Fixed » Closed (fixed)
geodaniel’s picture

geodaniel commented
Title: Using Microformat for address output » Using Microformat for address and coordinate output
Version: 4.7.x-1.x-dev » 5.x-1.x-dev
Status: Closed (fixed) » Needs work

I have just spotted a little bug in this: the latitude variable is being used twice, one in the right place and one in place of the longitude variable. Also, I can't see this in the current 5.x version of location.inc. Was it intentionally taken out in 1.45.2.5?

For testing these out by the way, the Operator toolbar for Firefox is very handy.

jiangxijay’s picture

jiangxijay commented

Has this been fixed?

bdragon’s picture

bdragon commented
Status: Needs work » Closed (duplicate)

It moved to the .theme file.
Fixed in seperate issue, thanks.

bdragon’s picture

bdragon commented

Committed a followup change to follow the recommendation from #16