Using Microformat for address and coordinate output

here comes the first patch for this.

Changes:

1. using hcard-Microformat at theme_location() and theme_location_de()
   One issue/question: What should we do (which hcard-class) with

$location['name']? We can't say if it is the organization or the name of a person or anything else...

removed ?> at the end of location.inc and location.de.inc

removed white space at the end of lines

Attachment	Size
location_microformat_vcard.patch.txt	43.29 KB

I forgot to mention that I added the $hide argument for functions like theme_location_de()...

btw. it seems like that this function can't be overwritten (like every other theme-function)

since the class "fn" is required I added this one to $location['name']

Attachment	Size
location_microformat_vcard.patch_0.txt	43.31 KB

Here is an example you can find on one of my sites:
standorte/waschsalon-albertrosshaupterstrasse-munchen

btw. I like the Tails extension for Firefox 2.0 to view and export microformats from websites.

This patch looks much bigger than it should, I'm guessing it's a line ending problem, either unix or windows based.

Not sure if location module had it wrong or your patch but be good to double check that :-)

it is so big, because I removed blanks in the end of lines...
They were so much so that this patch got far too big...
I putted this in an own patch: http://drupal.org/node/100830
it is really not an important patch, but the code looks cleaner IMHO...

I hope this patch works...

is clean now..

Attachment	Size
location_microformat_vcard.patch_1.txt	6.32 KB

Building on the patches above, I added http://microformats.org/wiki/geo support. My patch definitely needs review because a) I applied the above patches manually and ended up moving around some curly braces (some possibly in the wrong spot).

Attachment	Size
location.inc-vcard-geo.patch.txt	3.35 KB

Oh man. I gotta learn about microformats and geo-microformats before I can even test these patches? Any volunteers? I'm curious myself, but can't expense the time at the moment.

Taking a quick look at the microformat classes, I'm anxious to get both 'geo' and 'adr' class support.

Richard, if you're not sure your braces are in the right places, would you mind testing it and seeing if it works and outputs the appropriate HTML?

Tobias, would you be willing to a look if you get a chance. I would like to commit a verifiedly working version of this patch soon.

-Ankur

I added Richards' patch to my one and made it translatable

You can see it live at
http://www.muenchner-waschsalon.de/standorte/waschsalon-aidenbachstrasse...

But to be honest: I dont like the way lat/lon gets presented to the end user.
my second thought is that I dont even know if we should bother the end-user with such specific data like this...

Attachment	Size
location_microformat_vcard.patch_2.txt	7.2 KB

oh sorry
I tried a new editor which added a few new tabulators instead of two blanks.
here comes the corrected patch

Attachment	Size
location_microformat_vcard.patch_3.txt	7.22 KB

Hello Ankur,

whats your opinion about this?
Personally I prefer the version without lat/lon (#7).

Yeah, it would probably look aesthetically displeasing to have the lat/lon displayed for every address that has a pair figured out. Perhaps we can make it something configurable? or leave it up to the themer if the themer chooses to replace the theming function with one of their own.

Will update the patch so that it is configurable.

In the meantime, do microformats support fields that can be a part of a microformatting, but somehow hidden and parseable by something that collects microformat data?

Sure, you could hide the microformat text using CSS.

Would be a technique similar to one of these: http://www.mezzoblue.com/tests/revised-image-replacement/

That would probably be the best be to comply fully with the microformat, no?

For reference, this is exactly what Flickr does as evidenced here:

the right way to do the same what flickr does is

and if you want to never show it then this should be right

see point 5 of http://microformats.org/wiki/hcard#Semantic_XHTML_Design_Principles

Tobias, right on.

And we should *not* hardcode display:none, that should go into the CSS file.

Just wanted to illustrate the point that we can use the full geo format and CSS to hide what we don't need, just like Flickr. That way people can use CSS to turn on and off what they don't want.

Seems like that solves this issue -- time for an updated patch?

allright, here it is

it uses <abbr /> to hide latitude and longitude in general

Attachment	Size
location_microformat_vcard.patch_4.txt	6.93 KB

+1

Haven't tested the patch yet, but I like the idea of adding microformats for the addresses, and it fixes #109954 as well, which didn't close the tags properly in the .de include.

Applied to DRUPAL-4-7 and DRUPAL-5

subscribing

Pancho, you're subscribing to an issue that's been marked fixed? Did the application of this patch break something?

I have just spotted a little bug in this: the latitude variable is being used twice, one in the right place and one in place of the longitude variable. Also, I can't see this in the current 5.x version of location.inc. Was it intentionally taken out in 1.45.2.5?

For testing these out by the way, the Operator toolbar for Firefox is very handy.

Has this been fixed?

It moved to the .theme file.
Fixed in seperate issue, thanks.

Committed a followup change to follow the recommendation from #16