The current code in "better_messages.js" is very unhandy for translations:
$('.message-timer').text(Drupal.t('Closing in' + ' ' + seconds + ' ' + Drupal.t('seconds')));

I think it's much better if the line would look like this:
$('.message-timer').text(Drupal.t('Closing in @seconds seconds', { '@seconds': seconds }));

CommentFileSizeAuthor
#1 better_messages_translation.patch577 bytesdevworx_markus

Comments

devworx_markus’s picture

StatusFileSize
new577 bytes

Added patch of my changes

sleamey’s picture

Category: feature » bug

I think calling t() with variable arguments and (much worse) callin' t() inside of it's own argument should be considered as a bug...

bucefal91’s picture

Issue summary: View changes
Status: Active » Closed (outdated)

The 6.x version is no longer supported.