Hello Ron

I found that on my installation (about 18000 biblio entries) the execution time for the following query in function biblio_admin_orphans_form

$result = pager_query('SELECT * FROM {biblio_contributor_data} WHERE cid NOT IN (SELECT cid FROM {biblio_contributor} GROUP BY cid)', 50);

speeds up by about factor 5 when exchanged by 

  $result = pager_query('SELECT distinct d.cid cid, name, affiliation FROM {biblio_contributor_data} d left join {biblio_contributor} c on (d.cid=c.cid) WHERE c.cid is NULL', 50);

There is also a similar case in function biblio_admin_keyword_orphans_form which may hurt when there are a lot of keywords defined.

Comments

rjerome’s picture

rjerome commented
Status: Active » Fixed

Thanks for that Reiner, I tested it on a database with a few thousand authors and it definitely made a noticeable difference.

The changes have been committed... (to all branches, but 6.x-1.x listed below)

http://drupal.org/cvs?commit=462224

Ron.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.