Trying to use the 7.x version I get the following warnings:
Warning: Call-time pass-by-reference has been deprecated in sites\all\modules\computed_field\computed_field.module on line 163

Warning: Call-time pass-by-reference has been deprecated in sites\all\modules\computed_field\computed_field.module on line 175

Warning: Call-time pass-by-reference has been deprecated in sites\all\modules\computed_field\computed_field.module on line 184

CommentFileSizeAuthor
#4 patch1.patch1.81 KBAnonymous (not verified)
#3 computed_field_993576.patch4.4 KBmchelen

Comments

ryivhnn’s picture

ryivhnn commented

Search for &$ in computed_field.module and delete the &, if you haven't already.

aren cambre’s picture

aren cambre commented
Status: Needs review » Active

This eliminated the error messages for me.

mchelen’s picture

mchelen
he/him
commented
Status: Active » Needs review
StatusFileSize
new computed_field_993576.patch4.4 KB

Here is a patch for computed_field.module that replaces all instances of &$ with $ as suggested by #1. This appears to eliminate the warnings.

Anonymous’s picture

Anonymous (not verified) commented
Status: Active » Needs review
StatusFileSize
new patch1.patch1.81 KB

You should only replace the &$'s with $ is calls to _computed_field_compute_value(). The function definitions need to be declared as references so they correspond with the API doc. Also makes a difference if any of the referenced structures are modified.

Attached patch does that and also get's rid of a 'variable not defined' warning when enabling the module when there are no defined computed_field fields in use.

bfroehle’s picture

bfroehle commented
Status: Needs review » Reviewed & tested by the community

Patch is in the wrong format (apply with patch, not patch -p0), but I'll still mark as RTBC.

mchelen’s picture

mchelen
he/him
commented

Ah yes, the patch from #4 works, thanks!

Moonshine’s picture

Moonshine commented
Status: Reviewed & tested by the community » Closed (fixed)

Patch from #4 committed, thanks!