This is an initial working port for D7 from 6.x-2.x-dev branch, without Rules support. It works for core profile fields (have not test it yet on Profile2 module). It's supposed to be working exactly as the D6 version.

There is no new features, hopefully we can add them in the future.

CommentFileSizeAuthor
#6 d7_3.patch37.37 KBgood_man
#6 pcp_3.tar_.gz4.79 KBgood_man
#3 pcp-3.tar_.gz4.29 KBgood_man
pcp.tar_.gz4.31 KBgood_man

Comments

okokokok’s picture

okokokok commented

The block is not working for me and I'm getting some notices:

Notice: Undefined variable: nextfield in pcp_get_complete_percentage_data() (line 165 of /var/www/example.org/htdocs/sites/all/modules/custom/pcp/pcp.module).
Notice: Undefined variable: nextfield_fid in pcp_get_complete_percentage_data() (line 166 of /var/www/example.org/htdocs/sites/all/modules/custom/pcp/pcp.module).
Notice: Undefined variable: nextpercent in pcp_get_complete_percentage_data() (line 167 of /var/www/example.org/htdocs/sites/all/modules/custom/pcp/pcp.module).
Notice: Undefined variable: nextname in pcp_get_complete_percentage_data() (line 168 of /var/www/example.org/htdocs/sites/all/modules/custom/pcp/pcp.module).

okokokok’s picture

okokokok commented

Already better when actually checking "Make required for PCP module" for some fields. Still, no block and these notices:

Notice: Undefined index: 1 in pcp_get_complete_percentage_data() (line 137 of /var/www/example.org/htdocs/sites/all/modules/custom/pcp/pcp.module).
Notice: Undefined index: in pcp_get_complete_percentage_data() (line 139 of /var/www/example.org/htdocs/sites/all/modules/custom/pcp/pcp.module).
Notice: Undefined index: 1 in pcp_get_complete_percentage_data() (line 140 of /var/www/example.org/htdocs/sites/all/modules/custom/pcp/pcp.module).

good_man’s picture

good_man commented
StatusFileSize
new pcp-3.tar_.gz4.29 KB

Can you tell if it's still with this version in the attachment?

good_man’s picture

good_man commented

The previous version contains several bugs, will try to solve them and publish a new one soon.

good_man’s picture

good_man commented

@BarisW, I've fixed the bugs above, do you prefer a tar or patch to roll a D7 version?

good_man’s picture

good_man commented
StatusFileSize
new pcp_3.tar_.gz4.79 KB
new d7_3.patch37.37 KB

Ok here is a patch to commit and tarball for users to use directly of this module.

Fixed #2 bugs, and some other bugs & logics.

BarisW’s picture

BarisW commented

Thanks for your great work. I'll test it ASAP!

BarisW

BarisW’s picture

BarisW commented
Status: Active » Needs review
good_man’s picture

good_man commented

sorry forgot the review ;) and the patch is against current head.

BenK’s picture

BenK commented

Subscribing

BarisW’s picture

BarisW commented
Status: Needs review » Reviewed & tested by the community

I've tested the module and it looks great. It had a few small bugs which I've fixed at the #drupaldevdays.

- Delete the database entry when a field is deleted. Already in D6 version, but not in this one.
- The block still shows, even if all fields are filled in. Fixed it.
- Added a hook_uninstall() to delete all variables
- Minor typo's, added a t() wrapper around a string etc.

I think it's finished now. I will add a release within an hour.

BarisW’s picture

BarisW commented

I've released a 7.x-1.x-dev version.
See: http://drupal.org/node/1051084

Will be build by the Drupal packager within 12 hours.
Then please test. If you don't see any problems, I'll release a 1.0 :)

BarisW’s picture

BarisW commented
Status: Reviewed & tested by the community » Fixed
good_man’s picture

good_man commented

super! that was fast :)

BarisW’s picture

BarisW commented

Released! Thanks all ;)

http://drupal.org/node/1052066

cmsdeveloping’s picture

cmsdeveloping commented

Warning: Division by zero in pcp_get_complete_percentage_data() (line 155.........

i have changed the module with new released link above....but i receve this error.... :(

good_man’s picture

good_man commented

Can you please provide more info how this happened, and open a new issue so we can keep this issue only for D7 release.

BarisW’s picture

BarisW commented

By the way: you may have forgotten to first add some profile fields? Could this be the problem?
*reminds me to add a notice to the admin page to check if there are any profile fields available*

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.