please rename the "clone" to "node_clone" under administer > modules. makes it easier to find!

CommentFileSizeAuthor
#22 99436-22-D7.patch247 bytespwolanin

Comments

pwolanin’s picture

How about if I rename the project to "Clone content"?

pwolanin’s picture

Status: Active » Closed (won't fix)

no- that's going to cause too much confusion/headache. Maybe I'll update the README.

hass’s picture

why renaming the project? project name is ok, the only problem i have had is - inside drupal - i haven't found it.

every module is visible in the menu tree with the project name (e.g. administer > settings > node clone and administer > modules > node clone)... except node clone. this is all i'm talking about... it makes it easier. i read the module list ~10 times and every time i looked for "node..." and never "clone". every other projects list correct...

jeffschuler’s picture

Version: 4.7.x-1.0 » 6.x-1.0-beta2
Category: bug » feature
Status: Closed (won't fix) » Active

I know I'm raising the dead, but I agree.

Install via drush:

$ drush dl node_clone
Project node_clone (6.x-1.0) downloaded to {root}/sites/all/modules/.                  [success]

Great! Now enable:

$ drush enable node_clone
Module node_clone was not found and will not be enabled.                               [error]
There were no modules that could be enabled.                                           [ok]
An error occurred at function : drush_pm_enable                                        [error]

Hmm. Not called node_clone anymore...

Browse to admin/build/modules.
Find on page: "node clone"... nothing.
Find: "clone"...
Aha, called "Clone module"...

Why "Clone module"? We know it's a module.

Consistency reduces clicks, thoughts, grind.

Let's call it Node Clone / node_clone everywhere...

roball’s picture

Version: 6.x-1.0-beta2 » 6.x-1.0
pwolanin’s picture

Status: Active » Closed (won't fix)

Someone took the CVS directory I originally wanted: http://drupalcode.org/viewvc/drupal/contributions/modules/clone/

Sounds like this is a drush bug - please post there.

jeffschuler’s picture

This is not a drush bug. Just a request for consistency. Sorry if I caused confusing by showing the drush commands.

My point is that the module's "machine" name differs: node_clone in CVS but clone in module code,
...and it's "human" name differs: Node clone on Drupal.org but Clone module in clone.info

The point of relating my module install/enable experience, (both with drush then manually,) was to show how these inconsistencies affect that process.

babbage’s picture

Yep, I agree with jeffschuler, it's just a small speed bump in both installation with Drush and keeping track of things when machine names, d.o project names and human names don't line up predictably...

kriskhaira’s picture

This module is the only one I know with this annoyance. This ticket should really be re-opened.

It's not high-priority but it definitely should not be marked as "closed (won't fix)".

Let's brainstorm here. Some straightforward ideas:

- clone_content
- content_clone

Or get creative and find an interesting name:

- doppelganger
- dupe_something
- copy_machine
- cloning_machine
- clone_3000

machete1’s picture

Version: 6.x-1.0 » 6.x-1.2
Status: Closed (won't fix) » Needs review

I just installed this module today and was getting upset because I couldn't find the module in my list of modules.

As post #3,7,8,9 all state the name of this module in the Admin list doesn't follow Drupal consistency and creates frustration over something so minor to fix.

It's a great module and thanks for continuing to maintain the module... it would just help to stay in line with drupal's typical practices.

If you don't want change it - why not?

pwolanin’s picture

Version: 6.x-1.2 » 6.x-1.x-dev

renaming the .module file would be annoying for upgrade - I'll consider it for the 7.x version however.

The human name in the UI is easy to fix. patch?

machete1’s picture

I think the human name in the UI is all we are concerned about. I am not familiar with patches here at Drupal, but I quite capable of learning and thanks for being open to fixing the UI name :)

pwolanin’s picture

Docs are here: http://drupal.org/patch

note that there are a couple available git mirrors, which maybe be easier to use than CVS (and more useful to learn since we are switching to git as the vcs for all projects on drupal.org).

e.g.: http://git.drupalcode.org/project/node_clone.git

clone it as:

git clone git://git.drupalcode.org/project/node_clone.git

zzolo’s picture

Actually, having a difference between the project name (node_clone) and module name (clone) is more than just annoying. It could cause some serious issues with namespaces. If for some reason, someone started a clone module (as that project is not currently used) Drupal would explode if you tried to install both. Namespacing is really important in Drupal.

The Mapping Kit project has a submodule name openlayers, and this has caused problems with people installing the actual openlayers module as well. In a couple cases, people have lost data.

Not to mention the Drush annoyances, and just confusion, given the assumption of almost every project on Drupal.org.

I would very much suggest that you at least get the "clone" namespace and put a note there or something. If there is something in CVS, then you may have to go through Infrastructure to get rid of it. Then you can at least ensure there is not an explosion.

Great module and work!

pwolanin’s picture

Status: Needs review » Fixed

Grabbed this to prevent name space conflicts: http://drupal.org/project/clone

jeffschuler’s picture

Status: Fixed » Active

The risk zzolo brought up has been mitigated, but I don't believe the original issue is fixed.
Is the plan to rename the project entirely as "clone"?

pwolanin’s picture

Status: Active » Fixed

no, at this point I have no plan to rename the project.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

yurtboy’s picture

Any suggestions to using this in a drush make file?
Just stick with clone?
make file = projects[]= clone
and profile file for the install just use the name clone?

verta’s picture

Title: rename "clone" to "node_clone" » rename "clone" to "node clone"
Status: Closed (fixed) » Active

I am activating this feature request because I don't think the previous discussion explained the issue.

When you are looking for this module in the long list of modules at admin/modules, you need to be able to find it. The module is called 'node clone' but searching for that name will not find this module. Please call it "Node Clone" somewhere, in the name would be best, but in the string that describes it would help a little. I just went through this again to manage this module.

This is not a request to make a change to the code management system, but rather to what the module calls itself on admin/modules once it is installed.

Thank you.

verta’s picture

Title: rename "clone" to "node clone" » Rename "clone module" to "node clone" on admin/modules display

Since clone module is not actually what this module does, it clones a node, not clone a module.

(My take is that no module needs to have the word "module" in the description on admin/modules, really, they are all modules and I don't have any modules that do other than this one.)

pwolanin’s picture

Status: Active » Fixed
StatusFileSize
new247 bytes

committed to 6 and 7

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

  • Commit 574f2eb on 7.x-1.x, 8.x-1.x by pwolanin:
    Issue #99436 fix name in .info file
    
    
jadhavdevendra’s picture

Issue summary: View changes

In the module development, if you want to add dependency on this module you should use "clone" and not "node_clone". :(